Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump module Go version to 1.21 #351

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Feb 7, 2024

Bump module Go version to v1.21. Use slices package to simplify implementation.

@tri-adam tri-adam self-assigned this Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.26%. Comparing base (dd1e34c) to head (df206d4).

Files Patch % Lines
pkg/integrity/select.go 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   65.27%   65.26%   -0.01%     
==========================================
  Files          34       34              
  Lines        3266     3245      -21     
==========================================
- Hits         2132     2118      -14     
+ Misses        978      974       -4     
+ Partials      156      153       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tri-adam tri-adam force-pushed the go-1.22 branch 4 times, most recently from 6d2721f to d0b41d2 Compare February 9, 2024 16:13
@tri-adam tri-adam marked this pull request as ready for review February 9, 2024 16:16
dtrudg
dtrudg previously requested changes Feb 9, 2024
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold an a sec please - need to verify something wrt build that don't have access to Go 1.21 yet.

@dtrudg dtrudg dismissed their stale review March 19, 2024 16:37

Go ahead... we are month after 1.20 sunset, and I don't see movement on EPEL / EL. We shouldn't be beholden to them for extended periods of time.

@tri-adam tri-adam merged commit 796011b into sylabs:main Mar 19, 2024
1 check passed
@tri-adam tri-adam deleted the go-1.22 branch March 19, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants