Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split add/del/set code into files #364

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Jun 18, 2024

Split add/del/set code (and associated tests) into separate files. No code changes, purely moving code in this one.

@tri-adam tri-adam self-assigned this Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 78 lines in your changes missing coverage. Please review.

Project coverage is 62.65%. Comparing base (f2f07f5) to head (84ca397).

Files Patch % Lines
pkg/sif/set.go 50.00% 32 Missing and 16 partials ⚠️
pkg/sif/delete.go 76.13% 14 Missing and 7 partials ⚠️
pkg/sif/add.go 75.67% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   62.65%   62.65%           
=======================================
  Files          34       37    +3     
  Lines        3245     3245           
=======================================
  Hits         2033     2033           
  Misses       1046     1046           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tri-adam tri-adam marked this pull request as ready for review June 18, 2024 19:44
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tri-adam tri-adam merged commit 3c091b8 into sylabs:main Jun 19, 2024
1 check passed
@tri-adam tri-adam deleted the file-refactor branch June 19, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants