Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use DSSE wrappers from sigstore #366

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

tri-adam
Copy link
Member

Leverage DSSE wrappers from github.com/sigstore/sigstore, as they line up a little well with the Signer/Verifier we're using.

@tri-adam tri-adam self-assigned this Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 85.10638% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.59%. Comparing base (d63ee14) to head (fc6a037).

Files Patch % Lines
pkg/integrity/dsse.go 84.44% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   62.59%   62.59%           
=======================================
  Files          37       37           
  Lines        3280     3240   -40     
=======================================
- Hits         2053     2028   -25     
+ Misses       1056     1046   -10     
+ Partials      171      166    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tri-adam tri-adam marked this pull request as ready for review June 24, 2024 14:21
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tri-adam tri-adam merged commit d242f61 into sylabs:main Jun 24, 2024
1 check passed
@tri-adam tri-adam deleted the dsse-refactor branch June 24, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants