Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Go 1.18 (release-3.9) #606

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Feb 25, 2022

Adopt Go 1.18, advancing go.mod version to 1.17. Remove deprecated build constraint format.

A known issue remains between plugins and Go 1.18, as documented in #670. For this reason, the Go version used in the release-3.9 branch will remain at 1.17, pending a resolution to the discussion here.

@tri-adam tri-adam self-assigned this Feb 25, 2022
@tri-adam tri-adam force-pushed the go-1.18-release-3.9 branch from 01af50c to 014c70f Compare February 25, 2022 14:55
@tri-adam tri-adam force-pushed the go-1.18-release-3.9 branch from 014c70f to 097b1b1 Compare March 16, 2022 05:30
@dtrudg dtrudg force-pushed the go-1.18-release-3.9 branch from 097b1b1 to 8442662 Compare March 24, 2022 20:22
Adam Hughes and others added 2 commits March 30, 2022 16:55
Bump module language version to 1.17. Bump Go to 1.18 in CI. Remove
deprecated build constraint format.
@tri-adam tri-adam force-pushed the go-1.18-release-3.9 branch from 8442662 to 6c722d1 Compare March 30, 2022 16:55
@tri-adam tri-adam marked this pull request as ready for review March 30, 2022 17:23
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tri-adam tri-adam merged commit 9c1c1fe into sylabs:release-3.9 Mar 30, 2022
@tri-adam tri-adam deleted the go-1.18-release-3.9 branch March 30, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants