Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install scripts with new module name #4

Closed
wants to merge 1 commit into from

Conversation

csparker247
Copy link

Since the package name changed in de22a96, the setup script doesn't copy pyexiftool on install. This updates the script to use the new package name.

@csparker247
Copy link
Author

Just saw the conversation over on smarnach#31

Since it looks like this fork is going to get merged into mainline, I understand if this is closed without merge. Just be aware that install is currently broken.

@sylikc
Copy link
Owner

sylikc commented Feb 8, 2020

thanks Seth. Based on the conversation, I might undo that commit and send it back. Have you been using the tool for awhile?

@csparker247
Copy link
Author

No, I've just started using it. I'm doing some automatic image capture from machine vision cameras, and am having to add some of the basic metadata (make, model, aperture, exposure time, etc) as I acquire. I hit some issues with the upstream on Windows, so I switched to your fork to circumvent that.

@szero
Copy link

szero commented Apr 5, 2020

I'd like to mention that this and #5 makes this program installable with pip

@sylikc
Copy link
Owner

sylikc commented Apr 9, 2020

I'm going to roll back the pyexiftool rename, and stick with the "exiftool" name. It's been around for a long time, and ought not to rename it just for the sake of renaming

@sylikc
Copy link
Owner

sylikc commented Apr 9, 2020

rolled back the rename in the latest commit, so the fix is OBE

@sylikc sylikc closed this Apr 9, 2020
@csparker247 csparker247 deleted the fix-install-script branch April 9, 2020 13:02
@sylikc sylikc added the wontfix This will not be worked on label May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants