FIX Prevent popping open cms-menu when using nested gridfield #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/4/js-fix
branch
from
8d8bb0c to
1be045c
Compare
emteknetnz
force-pushed
the
pulls/4/js-fix
branch
2 times, most recently
from
d60097d to
e00c36c
Compare
emteknetnz
force-pushed
the
pulls/4/js-fix
branch
from
e00c36c to
c8cbc47
Compare
GuySartorelli
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #403
In LeftAndMain there's a handler for $(document).ajaxComplete() causing a redraw. This is resolved by using fetch() instead of jquerys ajax function.
Requires silverstripe/silverstripe-frameworktest#191 to be merged first