Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to detect when a user should use enumValues() #1

Open
silbinarywolf opened this issue Jun 29, 2017 · 3 comments
Open

Add rule to detect when a user should use enumValues() #1

silbinarywolf opened this issue Jun 29, 2017 · 3 comments

Comments

@silbinarywolf
Copy link
Contributor

silbinarywolf commented Jun 29, 2017

In getCMSFields() a user might not realize they can retrieve the enumValues() via dbObject, so throw an error if the fieldname is equal to a DBField that uses enum wherein it's just a constant array of enum values.

@silbinarywolf silbinarywolf self-assigned this Jun 29, 2017
silbinarywolf added a commit that referenced this issue Apr 25, 2018
@nglasl
Copy link
Contributor

nglasl commented Jan 7, 2019

@silbinarywolf can you please confirm if this is still an issue? I noticed a single commit reference above, but it seems unrelated? I assume you were using the numbers as iterations when working on something else.

@silbinarywolf
Copy link
Contributor Author

@nglasl Yep, unrelated commit. Still an improvement that can be made.

@nglasl
Copy link
Contributor

nglasl commented Jan 7, 2019

Sweet, thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants