API: Upgrade to phpstan 0.12

[sminnee]

Unfortunately retaining 0.11 support isn’t feasible but that seems like
an acceptable tradeoff.

Note that some of the type-hinting of DataLists will now be doable with
phpstan’s template features - we can type hint DataList for
example, and we can commit some @phpstan-return clauses to the core
framework to support this.

[mleutenegger]

@nglasl or any other maintainer, any chance to get this merged? It would be really nice to be able to upgrade to phpstan 0.12

[mleutenegger]

@sminnee I noticed that the suggested version in the composer.json file is still 0.11:

silverstripe-phpstan/composer.json

Lines 37 to 39 in 8f92c4d

	"suggest": {
	"phpstan/phpstan-shim": "~0.11.0"
	},

I think this should be changed to "phpstan/phpstan": "~0.12.0".

On a sidenote, I personally think that it would be beneficial to require phpstan/phpstan in the dependencies directly. The main arguments for this would be:

• The required version of phpstan is somewhat bound to the version of this module (eg. ^4.0 can only be used with phpstan 0.11, while the next version would be using phpstan 0.12 exclusively, the following one 1.0 and so on). This leads to basically having to upgrade this module alongside phpstan or vice-versa whenever one or the other updates.
• when using things like dependabot, updating phpstan is basically impossible to do automatically, as manual work will always have to be done to upgrade this module or phpstan.
• This module should be installed as a dev-dependency, so there would not be any pollution of production environments with the phpstan binary
• There is a better developer experience in only having to care about updating this module and not having to chase phpstan updates separately

Curious what you would think about this.

[marwan38]

@mleutenegger PHPStan is currently at version 1.4.10.. FYI

[mleutenegger]

PHPStan is currently at version 1.4.10.. FYI

@marwan38 Even more reason to get this working with newer versions and keep this maintained. As far as my comment was concerned, I was referring to the target version of this PR.

It would be a good idea to jump to the newest version, but this will probably require some additional work. Will have to check that and most likely add a new PR...

[sminnee]

@nglasl are you still using this much at Symbiote? If not, would it make sense to publish a fork? Perhaps @mleutenegger would be interested in maintaining such a fork?

[marwan38]

@sminnee I'm trying to develop this extension locally, but, I can't get it to run. Do you mind sharing how you set up this repo to be able to develop on it?

EDIT: Going to try cloning into vendor folder and requiring it by file

[mleutenegger]

@sminnee Actually, I already thought about creating and publishing a fork under the syntro/... namespace after opening an issue here asking wether this module is still actively maintained (which seems to not be the case ... 😔 ). As the module is basically part of the test pipeline of every client project and I personally like the idea of having a static analysis tool working with Silverstripe, I am somewhat interested in getting this back to an actively maintained state.

It would take some lifting to get it to work with the newest PHPStan version (especially https://phpstan.org/developing-extensions/always-read-written-properties is not happy with properties being used as config values).

[nglasl]

Sorry guys, I've moved on from Silverstripe development and I'm no longer a maintainer, however as I recall we weren't actively using this outside a single project.

[mleutenegger]

Perhaps @mleutenegger would be interested in maintaining such a fork?

@sminnee I have now created such a fork, as I was troubled with outdated dependencies & conflichts resolving them. Will start updating projects to use this fork in the near future.

It is compatible with the newest version of PHPStan and installs it as a dependency (so no more suggest) and so far seems to work fine. If interested, I would be grateful if you could give it a spin!