-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signing a Transaction Offline Guide #432
base: main
Are you sure you want to change the base?
Conversation
matthewkim93
commented
Jun 8, 2020
- 2 screeshots
- 1 example code (typescript)
- Both your offline and online :doc:`workstations <../../getting-started/setup-workstation.rst>` are set up for Symbol-CLI and Symbol-SDK. | ||
- You installed the `Symbol URI scheme <https://github.com/nemfoundation/symbol-uri-scheme>`_. | ||
|
||
*************************************************** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to show in a previous step how to create an offline account with the CLI.
You will have to pass to symbol-cli account generate
the options --network, --generation-hash, --namespace-id, and divisibility. Pass the option --help
to know more about each parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I included an optional step 0 (we can redo the numbering to if you think that's better. I showed how to generate an account. I'm not sure how you would save the account and create a transaction from the account with the cli without connecting to the internet though.
I wasn't too sure what you meant by "the options --network, --generation-hash, --namespace-id, and divisibility. Pass the option --help to know more about each parameter."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the guide to start at 1.
I'm not sure how you would save the account and create a transaction from the account with the cli without connecting to the internet though.
When creating a profile, the CLI retrieves some information automatically from the node connected. In order to create an account without having internet connection, the user needs to pass the following options manually: --generation-hash, --namespace-id, and --divisibility.
I attach in this image how I managed to create an account without internet:
Looks good to me, we will improve the process before merging to not have to open the SDK to construct the URI. |
Some notes to myself:
|
- 2 screeshots - 1 example code (typescript)
more background info optional step 0
There's still a lot of work to do here.
c6a473b
to
5631d6a
Compare