Skip to content

Commit

Permalink
feature #1330 Display source code using dark mode (javiereguiluz)
Browse files Browse the repository at this point in the history
This PR was merged into the main branch.

Discussion
----------

Display source code using dark mode

Creating a "dark mode" style for this application is outside of the scope of the project, so we're not going to do it.

However, I propose to use a "dark mode" style to display the source code in the modal windows. In addition to being the most common style for developers, showing it in "dark mode" further emphasizes the difference between the application interface and its code:

**Before / After**

![code-highlight-comparison](https://user-images.githubusercontent.com/73419/166917649-3d4d30a3-6f31-4cdc-a834-bfb82528a72f.jpg)

Commits
-------

0e1ff29 Display source code using dark mode
  • Loading branch information
javiereguiluz committed May 14, 2022
2 parents e7cc207 + 0e1ff29 commit 9b4e412
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion assets/styles/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ $lato-font-path: '~lato-font/fonts';
@import "~bootswatch/flatly/bootswatch";
@import "~@fortawesome/fontawesome-free/css/all.css";
@import "~@fortawesome/fontawesome-free/css/v4-shims.css";
@import "~highlight.js/styles/base16/solarized-light.css";
@import "~highlight.js/styles/github-dark-dimmed.css";

// pick the Lato fonts individually to avoid importing the entire font family
@import '~lato-font/scss/public-api';
Expand Down

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions public/build/979.dc75718b.css → public/build/347.484d2f6c.css

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions public/build/entrypoints.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
"/build/runtime.96aa4ea2.js",
"/build/755.f5cf308f.js",
"/build/498.3bafb5f9.js",
"/build/979.4967399b.js",
"/build/app.a5511055.js"
"/build/347.099e0365.js",
"/build/app.f1db5e65.js"
],
"css": [
"/build/979.dc75718b.css",
"/build/347.484d2f6c.css",
"/build/app.f66338b0.css"
]
},
Expand Down Expand Up @@ -46,9 +46,9 @@
"/build/runtime.96aa4ea2.js": "sha384-nMYLpi/v3txwhZt8UOBsMOTbgVmUPlpD8cPmrU3yblZ7Yg8l799XS9NC1BZ9P9Xs",
"/build/755.f5cf308f.js": "sha384-SAv+SyvZr31CmFrJFfKEYK0fDrMVx8vh19SI4QznAB/ar+Z1k6IT9Mg2SDZtLwD2",
"/build/498.3bafb5f9.js": "sha384-yoQvBlSFO4jMdQIBvie1V5XQ4M8F0CGnS2mFtS9RslTqLbW8IYO/xONlip3SUDGH",
"/build/979.4967399b.js": "sha384-IPkjWWHEhfdos/b3w08uBZ2KjTFno/Ocwt1o6ardQjWJEbigWocfHbAeZfj+t7AX",
"/build/app.a5511055.js": "sha384-t5u9zzpbS+SwUVCOSeCZdoFdZ5n1rIZ5nWHPzaEYkZ6U2oaG2AOokBmGXzL7uORK",
"/build/979.dc75718b.css": "sha384-3Xq9zpkhbAPpNpmbJIfOIsDjVugU/PSQ4vcam/DSyD65+CvSOnCrlxkY+RpzfNKN",
"/build/347.099e0365.js": "sha384-OyxwFmS/gA7lb0u0BQeQneUmxS+yTASnmvhmTgNdO3J02ghh4ZO8/qFdtMl/AhLr",
"/build/app.f1db5e65.js": "sha384-FRTtq8dHuogsqAkbmJ1Jq759Fo/3RWXiUUWpdkAF0j+ZD/MRx1mWfJjXBd86qs2R",
"/build/347.484d2f6c.css": "sha384-ZOokpnTV8wl6Db+viUkheay5Zi+h5AxTIUfrHzDQQQGBbpxSydOT+j8E619FtN6U",
"/build/app.f66338b0.css": "sha384-KA475JLog/ODk4eDLal8AC7va3Rpmyw4GCOfZJrhCxpm2B2itR0J3w1NAKF38hJ9",
"/build/login.395771d5.js": "sha384-bKBy5bAsLAFHFo/zxqJkheRiwvRSVHXwogJPw7DWc6qfnP03VaNFMyEc/0cRBf0k",
"/build/919.63ff4a5d.js": "sha384-0o9glCmkeYT/iE8RHdbPnoqMslSFjP/uN4ggsyjBVE5eq+V2RUFdEzYZBs5JNiyb",
Expand Down
6 changes: 3 additions & 3 deletions public/build/manifest.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"build/app.css": "/build/app.f66338b0.css",
"build/app.js": "/build/app.a5511055.js",
"build/app.js": "/build/app.f1db5e65.js",
"build/login.js": "/build/login.395771d5.js",
"build/admin.css": "/build/admin.691f9b8c.css",
"build/admin.js": "/build/admin.587634ca.js",
Expand All @@ -9,8 +9,8 @@
"build/755.f5cf308f.js": "/build/755.f5cf308f.js",
"build/498.3bafb5f9.js": "/build/498.3bafb5f9.js",
"build/919.63ff4a5d.js": "/build/919.63ff4a5d.js",
"build/979.dc75718b.css": "/build/979.dc75718b.css",
"build/979.4967399b.js": "/build/979.4967399b.js",
"build/347.484d2f6c.css": "/build/347.484d2f6c.css",
"build/347.099e0365.js": "/build/347.099e0365.js",
"build/95.ce62c8da.js": "/build/95.ce62c8da.js",
"build/images/fa-solid-900.svg": "/build/images/fa-solid-900.13de59f1.svg",
"build/images/fa-brands-400.svg": "/build/images/fa-brands-400.216edb96.svg",
Expand Down

0 comments on commit 9b4e412

Please sign in to comment.