Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the project to Symfony 6.3 #1415

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

javiereguiluz
Copy link
Member

This PR will be WIP until 6.3 is released as stable.

@javiereguiluz
Copy link
Member Author

I've updated to Symfony 6.3 beta 2 and I still see this direct deprecation:

deprecation

The problem is that a Symfony internal Logger class extends a Monolog class marked as final:

logger-class

I have two questions:

  • Why is it marked as "direct deprecation" instead of "indirect deprecation"?
  • Are we aware of this in the Symfony code repository so we can fix it before the final release?

@wouterj
Copy link
Member

wouterj commented May 9, 2023

Direct vs indirect may be a bug (the logic around this is a bit fragile).

The deprecation itself is known and unrelated to a Symfony upgrade, but rather a Monolog update: symfony/symfony#47096 There is no need to fix this before the final release

@stof
Copy link
Member

stof commented May 9, 2023

Direct vs indirect deprecation is fragile for deprecations triggered by the DebugClassLoader right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants