Skip to content

Commit

Permalink
Merge branch '4.4' into 5.2
Browse files Browse the repository at this point in the history
* 4.4:
  Backport type fixes
  uzb translation
  [DependencyInjection] Fix doc blocks
  [DependencyInjection] Turn $defaultDeprecationTemplate into a constant
  [Form] better form doc types to support static analysis
  • Loading branch information
nicolas-grekas committed Jul 2, 2021
2 parents 0ae3f04 + 87ece50 commit 6c6584c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions Iterator/SortableIterator.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ class SortableIterator implements \IteratorAggregate
private $sort;

/**
* @param \Traversable $iterator The Iterator to filter
* @param int|callable $sort The sort type (SORT_BY_NAME, SORT_BY_TYPE, or a PHP callback)
* @param int|callable $sort The sort type (SORT_BY_NAME, SORT_BY_TYPE, or a PHP callback)
*
* @throws \InvalidArgumentException
*/
Expand Down
2 changes: 1 addition & 1 deletion Tests/Iterator/SortableIteratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class SortableIteratorTest extends RealIteratorTestCase
public function testConstructor()
{
try {
new SortableIterator(new Iterator([]), 'foobar');
new SortableIterator(new Iterator([]), -255);
$this->fail('__construct() throws an \InvalidArgumentException exception if the mode is not valid');
} catch (\Exception $e) {
$this->assertInstanceOf(\InvalidArgumentException::class, $e, '__construct() throws an \InvalidArgumentException exception if the mode is not valid');
Expand Down

0 comments on commit 6c6584c

Please sign in to comment.