do not access typed properties before initialization

symfony · Oct 22, 2024 · 6e695b9 · 6e695b9
1 parent 4cbf327
commit 6e695b9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/KernelBrowser.php b/KernelBrowser.php
@@ -56,7 +56,7 @@ public function getKernel(): KernelInterface
      */
     public function getProfile(): HttpProfile|false|null
     {
-        if (null === $this->response || !$this->getContainer()->has('profiler')) {
+        if (!isset($this->response) || !$this->getContainer()->has('profiler')) {
             return false;
         }
 

diff --git a/Tests/KernelBrowserTest.php b/Tests/KernelBrowserTest.php
@@ -14,6 +14,7 @@
 use Symfony\Bundle\FrameworkBundle\KernelBrowser;
 use Symfony\Bundle\FrameworkBundle\Tests\Functional\AbstractWebTestCase;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\KernelInterface;
 
 class KernelBrowserTest extends AbstractWebTestCase
 {
@@ -61,6 +62,13 @@ public function testRequestAfterKernelShutdownAndPerformedRequest()
         $client->request('GET', '/');
     }
 
+    public function testGetProfileWithoutRequest()
+    {
+        $browser = new KernelBrowser($this->createMock(KernelInterface::class));
+
+        $this->assertFalse($browser->getProfile());
+    }
+
     private function getKernelMock()
     {
         $mock = $this->getMockBuilder($this->getKernelClass())