Skip to content

Commit

Permalink
remove legacy test dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
jrushlow committed Apr 24, 2024
1 parent 7863663 commit 6aa327f
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions tests/Maker/MakeSerializerEncoderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ protected function getMakerClass(): string
public function getTestDetails(): \Generator
{
yield 'it_makes_serializer_encoder' => [$this->createMakerTest()
// serializer-pack 1.1 requires symfony/property-info >= 5.4
// adding symfony/serializer-pack:* as an extra depends allows
// us to use serializer-pack < 1.1 which does not conflict with
// property-info < 5.4. E.g. Symfony 5.3 tests. See PR 1063
->addExtraDependencies('symfony/serializer-pack:*')
->run(function (MakerTestRunner $runner) {
if (70000 >= $runner->getSymfonyVersion()) {
$this->markTestSkipped('Legacy Symfony 6.4 Test');
Expand All @@ -52,11 +47,6 @@ public function getTestDetails(): \Generator

/* @legacy - Remove when MakerBundle no longer supports Symfony 6.4 */
yield 'it_makes_serializer_encoder_legacy' => [$this->createMakerTest()
// serializer-pack 1.1 requires symfony/property-info >= 5.4
// adding symfony/serializer-pack:* as an extra depends allows
// us to use serializer-pack < 1.1 which does not conflict with
// property-info < 5.4. E.g. Symfony 5.3 tests. See PR 1063
->addExtraDependencies('symfony/serializer-pack:*')
->run(function (MakerTestRunner $runner) {
if (70000 < $runner->getSymfonyVersion()) {
$this->markTestSkipped('Legacy Symfony 6.4 Test');
Expand Down

0 comments on commit 6aa327f

Please sign in to comment.