-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] fix symfony serializer deps in ci #1063
Conversation
|
ci failures are related make:entity & registration form.. the latter is getting a fix over in #1062 |
The underlying problem is that 1.1 of the I'm not sure of the best fix. If the user has Symfony 5.3, it's true that running the |
619de66
to
1d4d594
Compare
1d4d594
to
976a52b
Compare
Thanks Jesse! |
When running serializer tests in Symfony <= 5.3, composer attempts to use
symfony/serializer-pack@1.1
(The latest version at the time of this PR) which conflicts withsymfony/property-info
<5.4
. This in turn causes our tests to fail due to an uninstallable set of packages.As a work around, until something better comes along, adding
symfony/serializer-pack:*
as an extra test dependency allows lesser version ofserializer-pack
to be used in the test without conflict with its underlying packages.