[make:twig-component] Improve make:twig-component by reading the configuration file

[shadowc]

Small change in the way make:twig-component works when determining the namespace of the class to create.

In before, the namespace was hard coded. This is still good, but in cases where your Twig Component class namespace may have changed (i.e. your website is divided into src/Admin and src/Site and you've modified your twig_component.yaml so that your TwigComponents live under src/Site/Twig/Components), the component class would be still created under src/Twig/Components.

I've improved the command to read this config and automatically create the component under the first entry in this file. If no config is found, then we can use the old default.

TODOS:

• Can a test be made with a special config file?

[jrushlow]

Awesome Work! We do need a test case for this. we can probably just copy & paste this one ->

maker-bundle/tests/Maker/MakeTwigComponentTest.php

Line 22 in c305a02

yield 'it_generates_twig_component' => [$this->createMakerTest()

For the custom configuration file needed in the test ("fixture"), we would create that in maker-bundle/tests/fixtures/make-twig-components/custom_twig_component.yaml

Then in our test case, point to it using the $runner->copy() command. Similar to what we do here

maker-bundle/tests/Maker/MakeTwigComponentTest.php

Line 31 in c305a02

$runner->copy(

So it would look something like:

$runner->copy(
    'make-twig-component/tests/custom_twig_component.yaml',    // path to fixture (omit the tests/fixture prefix)
    'config/packages/twig_compont.yaml`.  // destination relative to the "test app's root"
); 

If any changes need to be made to the existing tests in the fixtures/make-twig-components to run in our new test, just copy the existing fixture file -> rename it to say "GeneratedComponentTwigTest_customNamespace.php" and modify the $runner->copy() appropriately`..

Hope this helps, if ya get stuck, slack or on here :)

[shadowc]

@jrushlow Hey, I created the test as you told me, but it's failing to load the config file! Let me know if I'm doing something wrong!

[shadowc]

I think this didn't work either...

[shadowc]

Ok, heads up: Thanks for all the help!! Looks like tests are passing and I've made the last changes of what as discussed! I think this is ready to go!

[jrushlow]

Awesome work @shadowc! Thank you!

[DaveData]

This breaks if config is in php files.

Maybe go with default if yaml file can't be read? Do we even need to open/parse the yaml file to get access to the value?

[shadowc]

@jrushlow hey! Let me know if I can fix this somehow? It seems we should be able to read php configs AND also default to the default value.