Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better message with full namespace #171

Merged
merged 1 commit into from
May 6, 2018
Merged

Better message with full namespace #171

merged 1 commit into from
May 6, 2018

Conversation

LeJeanbono
Copy link
Contributor

weaverryan
weaverryan reviewed May 4, 2018
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Could we include, somewhere in the message, that the App\ prefix is assumes. And so, use the full namespace if you want to use something different.

I just want to explain a bit why the generator is trying to put your class into some App namespace.

@weaverryan
Copy link
Member

Thank you @LeJeanbono!

@weaverryan weaverryan merged commit 5e9104c into symfony:master May 6, 2018
weaverryan added a commit that referenced this pull request May 6, 2018
@weaverryan
minor #171 Better message with full namespace (LeJeanbono)
5110979 
This PR was merged into the 1.0-dev branch.

Discussion
----------

Better message with full namespace

#133

Commits
-------

5e9104c Better message with full namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeJeanbono @weaverryan