Tag classes as final or internal based on their usages #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
Oct 24, 2023
OskarStark
approved these changes
Oct 24, 2023
derrabus
reviewed
Oct 24, 2023
| @@ -20,6 +20,8 @@ | |||
| * Registers processors in Monolog loggers or handlers. | |||
| * | |||
| * @author Christophe Coevoet <stof@notk.org> | |||
| * | |||
| * @internal since 3.8.0 | |||
There was a problem hiding this comment.
3.8.0 has been released already hasn't it.
There was a problem hiding this comment.
oh yeah. I messed up the version number. It should have been 3.9.0. I updated this.
stof
force-pushed
the
final_internal_classes
branch
from
0965d4a to
756093a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to have a clearer BC API for our future versions.