Update is_countable to include countable objects that doesn't impleme…

…nt \Countable
symfony · Apr 25, 2018 · b53929e · b53929e
1 parent 8d09841
commit b53929e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/Php73/bootstrap.php b/src/Php73/bootstrap.php
@@ -12,7 +12,10 @@
 if (PHP_VERSION_ID < 70300) {
     if (!function_exists('is_countable')) {
         function is_countable($var) {
-            return is_array($var) || $var instanceof Countable;
+            return is_array($var)
+                || $var instanceof Countable
+                || $var instanceof ResourceBundle
+                || $var instanceof SimpleXmlElement;
         }
     }
 }
diff --git a/tests/Php73/Php73Test.php b/tests/Php73/Php73Test.php
@@ -26,6 +26,8 @@ public function testIsCountable()
         $this->assertTrue(is_countable(array(1, 2, '3')));
         $this->assertTrue(is_countable(new \ArrayIterator(array('foo', 'bar', 'baz'))));
         $this->assertTrue(is_countable(new \ArrayIterator()));
+        $this->assertTrue(is_countable(new \SimpleXMLElement('<foo><bar/><bar/><bar/></foo>')));
+        $this->assertTrue(is_countable(\ResourceBundle::create('en', __DIR__.'/fixtures')));
         $this->assertFalse(is_countable(new \stdClass()));
     }
 

diff --git a/tests/Php73/fixtures/en.res b/tests/Php73/fixtures/en.res