Update is_countable to include countable objects that doesn't implement \Countable #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pierredup Is there any way to find all of then? |
|
I used https://github.com/php/php-src/search?utf8=✓&q=count_elements&type= as a simple check, which should cover everything in core. The other items found in the result (SplHeap, DoublyLinkedList, SplFixedArray etc) already implement Countable |
|
Thank you @pierredup. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 26, 2018
…t implement \Countable (pierredup) This PR was merged into the 1.8-dev branch. Discussion ---------- Update is_countable to include countable objects that doesn't implement \Countable Some objects are countable but don't implement `Countable` ([#115#issuecomment-384361414](#115 (comment))) The objects that I could identify that is countable is `ResourceBundle` and `SimpleXmlElement` Commits ------- b53929e Update is_countable to include countable objects that doesn't implement \Countable
Ayesh
reviewed
May 6, 2018
| @@ -26,6 +26,8 @@ public function testIsCountable() | |||
| $this->assertTrue(is_countable(array(1, 2, '3'))); | |||
| $this->assertTrue(is_countable(new \ArrayIterator(array('foo', 'bar', 'baz')))); | |||
| $this->assertTrue(is_countable(new \ArrayIterator())); | |||
| $this->assertTrue(is_countable(new \SimpleXMLElement('<foo><bar/><bar/><bar/></foo>'))); | |||
| $this->assertTrue(is_countable(\ResourceBundle::create('en', __DIR__.'/fixtures'))); | |||
There was a problem hiding this comment.
Don't we need class_exists() calls for these two to make sure intl and xml extensions are loaded.
There was a problem hiding this comment.
In Travis the extensions are loaded so the classes should always exist. In the actual polyfill, the check would just return false if the extension isn't loaded and the class doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some objects are countable but don't implement
Countable(symfony/polyfill#115#issuecomment-384361414)The objects that I could identify that is countable is
ResourceBundleandSimpleXmlElement