Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix function signature tests #486

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix function signature tests #486

merged 1 commit into from
Sep 9, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 30, 2024

No description provided.

@stof
Copy link
Member

stof commented Jul 30, 2024 •
edited
Loading

IIRC, allowing null was done to allow compatibility with the coalescing mode of PHP's type, which allows null (but deprecated) until PHP 9 for native functions

@xabbuh xabbuh force-pushed the php8-signatures branch from d684094 to 47e4090 Compare July 30, 2024 12:19
@nicolas-grekas
Copy link
Member

@stof is right

@xabbuh xabbuh force-pushed the php8-signatures branch 2 times, most recently from 44afb9d to 36622a8 Compare July 30, 2024 12:27
@xabbuh xabbuh changed the title fix function signatures for parity with native functions in PHP 8 fix function signature tests Jul 30, 2024
@xabbuh xabbuh force-pushed the php8-signatures branch 3 times, most recently from 3662eae to b940a59 Compare July 30, 2024 12:36
@xabbuh xabbuh force-pushed the php8-signatures branch from b940a59 to 4d0166f Compare July 30, 2024 12:38
@xabbuh
Copy link
Member Author

xabbuh commented Jul 30, 2024

makes sense, I added two additional entries to the map to satisfy the tests instead

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 1419e0d into symfony:1.x Sep 9, 2024
6 of 10 checks passed
@xabbuh xabbuh deleted the php8-signatures branch September 9, 2024 07:51
@nicolas-grekas nicolas-grekas mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @stof @nicolas-grekas