Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sylius/refund-plugin recipe improvements #560

Closed
wants to merge 1 commit into from
Closed

sylius/refund-plugin recipe improvements #560

wants to merge 1 commit into from

Conversation

Zales0123
Copy link
Contributor

Q A
License MIT

It is meant to automatize 3rd point from installation instruction.

ghost
ghost approved these changes Nov 20, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from 3928e27 to 9e997fc Compare November 20, 2018 10:24
ghost
ghost approved these changes Nov 20, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from 9e997fc to ad2cb50 Compare November 20, 2018 11:25
ghost
ghost approved these changes Nov 20, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from ad2cb50 to a0d69ab Compare November 20, 2018 11:27
ghost
ghost approved these changes Nov 20, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from a0d69ab to 8f7e7db Compare February 20, 2019 19:24
ghost
ghost suggested changes Feb 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from 8f7e7db to c88cda1 Compare February 20, 2019 19:25
ghost
ghost approved these changes Feb 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from c88cda1 to 7261f8f Compare February 20, 2019 19:34
ghost
ghost approved these changes Feb 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from 7261f8f to d4d39ad Compare February 20, 2019 19:37
ghost
ghost approved these changes Feb 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from d4d39ad to 30e6b4a Compare February 20, 2019 19:40
ghost
ghost approved these changes Feb 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from 30e6b4a to 5f6f998 Compare February 20, 2019 19:50
ghost
ghost approved these changes Feb 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from 5f6f998 to 8af294d Compare February 20, 2019 19:56
ghost
ghost suggested changes Feb 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

sylius/refund-plugin/0.4/config/packages/_sylius.yaml Outdated

- { resource: "@SyliusShopBundle/Resources/config/app/config.yml" }

parameters:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"parameters" should be defined via the "container" configurator instead

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from 8af294d to 6d9a2e1 Compare February 20, 2019 19:59
ghost
ghost approved these changes Feb 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from 6d9a2e1 to 80875fa Compare February 20, 2019 21:12
ghost
ghost approved these changes Feb 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Nyholm
Nyholm requested changes Apr 6, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

#eu-fossa

sylius/refund-plugin/0.4/manifest.json Outdated
"Sylius\\Bundle\\CoreBundle\\SyliusCoreBundle": ["all"],
"Sylius\\Bundle\\GridBundle\\SyliusGridBundle": ["all"],
"Sylius\\Bundle\\MailerBundle\\SyliusMailerBundle": ["all"],
"Sylius\\Bundle\\ResourceBundle\\SyliusResourceBundle": ["all"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These bundles is not part of the package. We should never modify other bundles in this recipe.

@Nyholm
Copy link
Member

Nyholm commented Jun 29, 2019

Any updates here?

@Nyholm
Copy link
Member

Nyholm commented Aug 13, 2019

Friendly ping

@Zales0123
Copy link
Contributor Author

Sorry for the long response time, I've totally missed it :/ I had no time to work on this for some time recently, but for sure I want to make it work and will try as fast as possible :)

@Zales0123 Zales0123 force-pushed the improve-sylius-refund-plugin-recipe branch from 80875fa to aa8397f Compare November 20, 2019 17:08
ghost
ghost approved these changes Nov 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Zales0123
Copy link
Contributor Author

Ok, so it's been a long time, sorry for that 🖖 Right now it won't work, as the plugin requires Sylius to work and Sylius does not have a recipe defined... So I'll allow myself to close it (in the end, it's just an improvement), to not litter the PR's list and when we would have a recipe for Sylius and/or its bundles itself (I hope sooner than later ;)) I'll come back with it. Thanks a lot for Flex and Symfony! 🚀

@Zales0123 Zales0123 closed this Nov 23, 2019
@Zales0123 Zales0123 mentioned this pull request Feb 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zales0123 @Nyholm