Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Symfony UX Map] Add post-install steps for Leaflet and Google, add "ux_map.google_maps.default_map_id" config recipe #1354

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Nov 10, 2024

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

Follow symfony/ux#2358, I've also added post-install steps.

Version 2.22 is not released yet, but 2.19 is
image

Copy link

github-actions bot commented Nov 10, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1354/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1354/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/ux-google-map:^2.22' 'symfony/ux-leaflet-map:^2.19'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

symfony/ux-google-map

2.19 vs 2.22
diff --git a/symfony/ux-google-map/2.19/manifest.json b/symfony/ux-google-map/2.22/manifest.json
index 0adf0fc..eb14c9e 100644
--- a/symfony/ux-google-map/2.19/manifest.json
+++ b/symfony/ux-google-map/2.22/manifest.json
@@ -2,6 +2,15 @@
     "conflict": {
         "symfony/flex": "<1.20.0 || >=2.0.0,<2.3.0"
     },
+    "add-lines": [
+        {
+            "file": "config/packages/ux_map.yaml",
+            "position": "after_target",
+            "warn_if_missing": true,
+            "target": "    renderer: '%env(resolve:default::UX_MAP_DSN)%'",
+            "content": "    google_maps:\n        # define the default map id for all maps (https://developers.google.com/maps/documentation/get-map-id)\n        default_map_id: null"
+        }
+    ],
     "env": {
         "#1": "Options available at https://github.com/symfony/ux/blob/2.x/src/Map/src/Bridge/Google/README.md",
         "#2": "",

auto-merge was automatically disabled November 10, 2024 22:40

Head branch was pushed to by a user without write access

@Kocal Kocal force-pushed the imp-ux-map-recipes branch from 84f9f34 to 23244b1 Compare November 10, 2024 22:40
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 10, 2024 22:40
fabpot
fabpot previously approved these changes Nov 11, 2024
@fabpot fabpot disabled auto-merge November 11, 2024 10:15
symfony/ux-google-map/2.22/manifest.json Outdated Show resolved Hide resolved
symfony/ux-google-map/2.22/post-install.txt Outdated Show resolved Hide resolved
symfony/ux-leaflet-map/2.19/post-install.txt Outdated Show resolved Hide resolved
symfony/ux-google-map/2.19/post-install.txt Outdated Show resolved Hide resolved
…ux_map.google_maps.default_map_id" config recipe
@fabpot fabpot disabled auto-merge November 14, 2024 07:51
@fabpot fabpot merged commit 4dbcd95 into symfony:main Nov 14, 2024
1 of 2 checks passed
@Kocal Kocal deleted the imp-ux-map-recipes branch November 14, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants