Skip to content

Commit

Permalink
Replaced setDefaultOptions by the new configureOptions method
Browse files Browse the repository at this point in the history
  • Loading branch information
peterrehm authored and weaverryan committed Jan 21, 2015
1 parent 7363c9b commit 728205f
Show file tree
Hide file tree
Showing 12 changed files with 49 additions and 53 deletions.
4 changes: 2 additions & 2 deletions best_practices/forms.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ form in its own PHP class::

use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class PostType extends AbstractType
{
Expand All @@ -36,7 +36,7 @@ form in its own PHP class::
;
}

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'data_class' => 'AppBundle\Entity\Post'
Expand Down
34 changes: 17 additions & 17 deletions book/forms.rst
Original file line number Diff line number Diff line change
Expand Up @@ -471,12 +471,12 @@ you'll need to specify which validation group(s) your form should use::
))->add(...);

If you're creating :ref:`form classes <book-form-creating-form-classes>` (a
good practice), then you'll need to add the following to the ``setDefaultOptions()``
good practice), then you'll need to add the following to the ``configureOptions()``
method::

use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'validation_groups' => array('registration'),
Expand All @@ -498,9 +498,9 @@ Disabling Validation
Sometimes it is useful to suppress the validation of a form altogether. For
these cases you can set the ``validation_groups`` option to ``false``::

use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'validation_groups' => false,
Expand All @@ -524,10 +524,10 @@ If you need some advanced logic to determine the validation groups (e.g.
based on submitted data), you can set the ``validation_groups`` option
to an array callback::

use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

// ...
public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'validation_groups' => array(
Expand All @@ -544,10 +544,10 @@ You can also define whole logic inline by using a ``Closure``::

use Acme\AcmeBundle\Entity\Client;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

// ...
public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'validation_groups' => function(FormInterface $form) {
Expand All @@ -567,10 +567,10 @@ of the entity as well you have to adjust the option as follows::

use Acme\AcmeBundle\Entity\Client;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

// ...
public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'validation_groups' => function(FormInterface $form) {
Expand Down Expand Up @@ -1090,9 +1090,9 @@ the choice is ultimately up to you.
good idea to explicitly specify the ``data_class`` option by adding the
following to your form type class::

use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'data_class' => 'AppBundle\Entity\Task',
Expand Down Expand Up @@ -1321,7 +1321,7 @@ create a form class so that a ``Category`` object can be modified by the user::

use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class CategoryType extends AbstractType
{
Expand All @@ -1330,7 +1330,7 @@ create a form class so that a ``Category`` object can be modified by the user::
$builder->add('name');
}

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'data_class' => 'AppBundle\Entity\Category',
Expand Down Expand Up @@ -1756,13 +1756,13 @@ that all un-rendered fields are output.

The CSRF token can be customized on a form-by-form basis. For example::

use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class TaskType extends AbstractType
{
// ...

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'data_class' => 'AppBundle\Entity\Task',
Expand Down
4 changes: 2 additions & 2 deletions cookbook/doctrine/registration_form.rst
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ Next, create the form for the ``User`` model::

use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class UserType extends AbstractType
{
Expand All @@ -125,7 +125,7 @@ Next, create the form for the ``User`` model::
));
}

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'data_class' => 'Acme\AccountBundle\Entity\User'
Expand Down
10 changes: 5 additions & 5 deletions cookbook/form/create_custom_field_type.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ for form fields, which is ``<BundleName>\Form\Type``. Make sure the field extend
namespace AppBundle\Form\Type;

use Symfony\Component\Form\AbstractType;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class GenderType extends AbstractType
{
public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'choices' => array(
Expand Down Expand Up @@ -72,7 +72,7 @@ important:
set) the ``multiple`` attribute on the ``select`` field. See `Creating a Template for the Field`_
for more details.

``setDefaultOptions()``
``configureOptions()``
This defines options for your form type that
can be used in ``buildForm()`` and ``buildView()``. There are a lot of
options common to all fields (see :doc:`/reference/forms/types/form`),
Expand Down Expand Up @@ -345,7 +345,7 @@ method to ``GenderType``, which receives the gender configuration::
// src/AppBundle/Form/Type/GenderType.php
namespace AppBundle\Form\Type;

use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

// ...

Expand All @@ -359,7 +359,7 @@ method to ``GenderType``, which receives the gender configuration::
$this->genderChoices = $genderChoices;
}

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'choices' => $this->genderChoices,
Expand Down
8 changes: 4 additions & 4 deletions cookbook/form/create_form_type_extension.rst
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ to override one of the following methods:

* ``buildView()``

* ``setDefaultOptions()``
* ``configureOptions()``

* ``finishView()``

Expand Down Expand Up @@ -178,7 +178,7 @@ database)::
Your form type extension class will need to do two things in order to extend
the ``file`` form type:

#. Override the ``setDefaultOptions`` method in order to add an ``image_path``
#. Override the ``configureOptions`` method in order to add an ``image_path``
option;
#. Override the ``buildForm`` and ``buildView`` methods in order to pass the image
URL to the view.
Expand Down Expand Up @@ -212,9 +212,9 @@ it in the view::
/**
* Add the image_path option
*
* @param OptionsResolverInterface $resolver
* @param OptionsResolver $resolver
*/
public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setOptional(array('image_path'));
}
Expand Down
9 changes: 5 additions & 4 deletions cookbook/form/data_transformers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,9 @@ You can also use transformers without creating a new custom form type
by calling ``addModelTransformer`` (or ``addViewTransformer`` - see
`Model and View Transformers`_) on any field builder::

use Symfony\Component\Form\FormBuilderInterface;
use Acme\TaskBundle\Form\DataTransformer\IssueToNumberTransformer;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class TaskType extends AbstractType
{
Expand All @@ -133,7 +134,7 @@ by calling ``addModelTransformer`` (or ``addViewTransformer`` - see
);
}

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver
->setDefaults(array(
Expand Down Expand Up @@ -254,7 +255,7 @@ First, create the custom field type class::
use Symfony\Component\Form\FormBuilderInterface;
use Acme\TaskBundle\Form\DataTransformer\IssueToNumberTransformer;
use Doctrine\Common\Persistence\ObjectManager;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class IssueSelectorType extends AbstractType
{
Expand All @@ -277,7 +278,7 @@ First, create the custom field type class::
$builder->addModelTransformer($transformer);
}

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolverInterface $resolver)
{
$resolver->setDefaults(array(
'invalid_message' => 'The selected issue does not exist',
Expand Down
9 changes: 2 additions & 7 deletions cookbook/form/dynamic_form_modification.rst
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ a bare form class looks like::

use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class ProductType extends AbstractType
{
Expand All @@ -51,7 +51,7 @@ a bare form class looks like::
$builder->add('price');
}

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'data_class' => 'AppBundle\Entity\Product'
Expand Down Expand Up @@ -224,7 +224,6 @@ Using an event listener, your form might look like this::
use Symfony\Component\Form\FormEvents;
use Symfony\Component\Form\FormEvent;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;

class FriendMessageFormType extends AbstractType
{
Expand All @@ -243,10 +242,6 @@ Using an event listener, your form might look like this::
{
return 'acme_friend_message';
}

public function setDefaultOptions(OptionsResolverInterface $resolver)
{
}
}

The problem is now to get the current user and create a choice field that
Expand Down
8 changes: 4 additions & 4 deletions cookbook/form/form_collections.rst
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ Then, create a form class so that a ``Tag`` object can be modified by the user::

use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class TagType extends AbstractType
{
Expand All @@ -93,7 +93,7 @@ Then, create a form class so that a ``Tag`` object can be modified by the user::
$builder->add('name');
}

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'data_class' => 'Acme\TaskBundle\Entity\Tag',
Expand All @@ -118,7 +118,7 @@ Notice that you embed a collection of ``TagType`` forms using the

use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class TaskType extends AbstractType
{
Expand All @@ -129,7 +129,7 @@ Notice that you embed a collection of ``TagType`` forms using the
$builder->add('tags', 'collection', array('type' => new TagType()));
}

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'data_class' => 'Acme\TaskBundle\Entity\Task',
Expand Down
4 changes: 2 additions & 2 deletions cookbook/form/inherit_data_option.rst
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ for that::

use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class LocationType extends AbstractType
{
Expand All @@ -103,7 +103,7 @@ for that::
->add('country', 'text');
}

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'inherit_data' => true
Expand Down
8 changes: 4 additions & 4 deletions cookbook/form/use_empty_data.rst
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ that constructor with no arguments::
// ...
use Symfony\Component\Form\AbstractType;
use AppBundle\Entity\Blog;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class BlogType extends AbstractType
{
Expand All @@ -51,7 +51,7 @@ that constructor with no arguments::
}
// ...

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'empty_data' => new Blog($this->someDependency),
Expand All @@ -72,11 +72,11 @@ if it is needed.

The closure must accept a ``FormInterface`` instance as the first argument::

use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\Component\Form\FormInterface;
// ...

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'empty_data' => function (FormInterface $form) {
Expand Down
2 changes: 1 addition & 1 deletion reference/dic_tags.rst
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ the interface directly::
class MyFormTypeExtension extends AbstractTypeExtension
{
// ... fill in whatever methods you want to override
// like buildForm(), buildView(), finishView(), setDefaultOptions()
// like buildForm(), buildView(), finishView(), configureOptions()
}
In order for Symfony to know about your form extension and use it, give it
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/options/error_mapping.rst.inc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ of the form.
With customized error mapping, you can do better: map the error to the city
field so that it displays above it::

public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'error_mapping' => array(
Expand Down

0 comments on commit 728205f

Please sign in to comment.