Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Components][Translation] Custom loaders and dumpers #4156

Closed
raulfraile opened this issue Aug 21, 2014 · 2 comments
Closed

[Components][Translation] Custom loaders and dumpers #4156

raulfraile opened this issue Aug 21, 2014 · 2 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Translation

Comments

@raulfraile
Copy link
Contributor

There is no documentation about custom loaders and dumpers for the translation component. Custom loaders/dumpers can be used to support old/custom formats for translation files.

The idea would be to port what I wrote in this post: http://blog.servergrove.com/2014/03/18/symfony2-components-overview-translation/ ("custom loaders" part). If you think it can be useful, I can do it in the next DX hackday.
@javiereguiluz
Copy link
Member

@raulfraile thanks for creating this issue and for taking part in the DX initiative. We really appreciate it!

I'm 👍 about your proposal. Given that the translation component already supports lots of common formats, this is a feature that it's not very commonly used by end developers. However, I'd like to document it precisely for being such a dark part of Symfony. Moreover, this could be a clear example of how Symfony is flexible enough to adapt to your needs, no matter how custom they are.

By the way, congratulations on your series of blog posts, which I read and enjoyed!

@raulfraile raulfraile mentioned this issue Aug 22, 2014
Merged
weaverryan added a commit that referenced this issue Sep 16, 2014
@weaverryan
feature #4166 Translation custom loaders (raulfraile)
a8dc2bf 
This PR was merged into the 2.3 branch.

Discussion
----------

Translation custom loaders

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #4156

This PR adds a documentation section for creating custom loaders and dumpers to support other formats.

Commits
-------

69491ae Improved custom formats article based on comments
c0f3b0a Fixed wrong indentation
629a008 Extra improvements based on comments
bfd78b3 Improvements based on comments
105a168 Cleanups
e2fd5fa Small fixes
dee7fb2 Link from introduction section
8b6c584 Added custom format page to translation component
@wouterj
Copy link
Member

wouterj commented Dec 13, 2014

Fixed by #4166
For some reason, it looks like GH forgets to close the issue in case some PRs are merged.

@wouterj wouterj closed this as completed Dec 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @raulfraile @wouterj