-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly Document how to override core classes #4234
Comments
Please note that this duplicates what I proposed in #4228:
|
@weaverryan Is it possible to put this in the 2.6 milestone? Especially with new services not having |
@iltar that's not how we use the milestones. Milestones in de docs indicate only new features which needs to be documented for a specific version. This should be done for all versions. It's still an issue that's high on my prioritylist btw. |
I agree this should be done soon, and me can merge it into all branches, which is really nice :). Cheers! |
I've got a service here that might want some love and attention. A lot of people need the following service but a bit more customized, without copying all the code to a SimpleAuthenticatorInterface implementation. I often see question related to this in security.authentication.provider.dao - Using a decorator around |
Closing in favor of #4228 |
Hi guys!
First, see symfony/symfony#11881. Basically, we should be using service decoration and not recommending that you override any
*class
parameters. We do talk about service decoration incomponents/dependency_injection/advanced.rst
, but I propose that we show a quick cookbook article on how to override a real core service.It might also be nice to change the existing article to use examples better than foo and bar :). See https://github.com/symfony/symfony-docs/pull/3753/files#r17416550.
The text was updated successfully, but these errors were encountered: