Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split "Advanced Container Configuration" article #4228

Closed
2 of 3 tasks
wouterj opened this issue Sep 14, 2014 · 3 comments
Closed
2 of 3 tasks

Split "Advanced Container Configuration" article #4228

wouterj opened this issue Sep 14, 2014 · 3 comments
Labels
actionable Clear and specific issues ready for anyone to take them. DependencyInjection

Comments

@wouterj
Copy link
Member

wouterj commented Sep 14, 2014

This article (which lives in components/dependency_injection) is some sort of dump place for all topics which we couldn't place anywhere else. This doesn't make it easy to find, while some topics in there are really best practises which should be advertised more.

  • Three topics ("Marking services as public/private", "Aliasing" and "Decorating Services") are related to the way you make your services open for extensibility. This should be moved into a new article, telling you everything about these concepts and learning you best practises.
  • The "Synthetic Services" topic can also be moved to its own chapter, telling you how to inject instances into the container.
  • At last, the "Requiring files" topic can be moved to a simple sidebar in the introduction chapter.
@wouterj wouterj added actionable Clear and specific issues ready for anyone to take them. DependencyInjection labels Sep 14, 2014
@weaverryan
Copy link
Member

Good idea - I don't see a downside to this.

@wouterj wouterj mentioned this issue Sep 16, 2014
Closed
@jakzal jakzal mentioned this issue Nov 28, 2014
Closed
@wouterj wouterj mentioned this issue Apr 3, 2015
Closed
@wouterj wouterj changed the title Remove "Advanced Container Configuration" article Split "Advanced Container Configuration" article May 2, 2015
wouterj added a commit to wouterj/symfony-docs that referenced this issue May 23, 2015
@wouterj
[symfony#4228] Moved requiring files to definitions
26c7813
wouterj added a commit to wouterj/symfony-docs that referenced this issue May 23, 2015
@wouterj
[symfony#4228] Move synthetic services to its own recipe
8260f6f
@wouterj wouterj mentioned this issue May 23, 2015
Merged
@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label May 23, 2015
wouterj added a commit to wouterj/symfony-docs that referenced this issue Jun 7, 2015
@wouterj
[symfony#4228] Move synthetic services to its own recipe
e3c2603
weaverryan added a commit that referenced this issue Jun 11, 2015
@weaverryan
minor #5284 Split advanced container configuration article (WouterJ)
4566d33 
This PR was merged into the 2.3 branch.

Discussion
----------

Split advanced container configuration article

| Q | A
| --- | ---
| Doc fixes? | yes
| New docs? | yes
| Applies to | all
| Fixed tickets | #4228 (partially, 2 and 3)

Commits
-------

e3c2603 [#4228] Move synthetic services to its own recipe
26c7813 [#4228] Moved requiring files to definitions
weaverryan added a commit that referenced this issue Jun 19, 2015
@weaverryan
Merge branch '2.3' into 2.6
34c1293 
* 2.3:
  [#5373] Small tweak per Stof's comment
  Fixed a minor grammar issue
  Fixed typos
  Link to the official repository of the bundle.
  Added mentions to some popular (and useful) Symfony bundles
  [#5095] Fixing a typo and updating to a more realistic example
  [#4228] Move synthetic services to its own recipe
  clarify bundle installation instructions
  Implemented the suggestions made by Christian and Wouter
  Replace phpDocumentor by the standard PHPDoc
  Implemented the changes suggested by reviewers
  Fixed an internal link reference
  Reviewed the Bundles cookbook articles
  Constraints - empty strings and null values
  Add a caution to the getUploadRootDir - correction
  Adding a caution to the getUploadRootDir() method
  [#4228] Moved requiring files to definitions
weaverryan added a commit that referenced this issue Jun 19, 2015
@weaverryan
Merge branch '2.6' into 2.7
db2edca 
* 2.6:
  [#5373] Small tweak per Stof's comment
  Fixed a minor grammar issue
  Fixed typos
  Link to the official repository of the bundle.
  Added mentions to some popular (and useful) Symfony bundles
  [#5095] Fixing a typo and updating to a more realistic example
  [Components][ClassLoader] remove DebugClassLoader
  [#4228] Move synthetic services to its own recipe
  clarify bundle installation instructions
  Implemented the suggestions made by Christian and Wouter
  Replace phpDocumentor by the standard PHPDoc
  Implemented the changes suggested by reviewers
  Fixed an internal link reference
  Reviewed the Bundles cookbook articles
  Constraints - empty strings and null values
  Add a caution to the getUploadRootDir - correction
  Adding a caution to the getUploadRootDir() method
  [#4228] Moved requiring files to definitions
weaverryan added a commit that referenced this issue Jun 19, 2015
@weaverryan
Merge branch '2.7' into 2.8
bfea184 
* 2.7: (23 commits)
  [#5331] Tiny typo
  [#5373] Small tweak per Stof's comment
  [PSR-7] Bridge documentation
  Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7
  Fixed a minor grammar issue
  Fixed typos
  Link to the official repository of the bundle.
  Added mentions to some popular (and useful) Symfony bundles
  [#5095] Fixing a typo and updating to a more realistic example
  [Components][ClassLoader] remove DebugClassLoader
  [#4228] Move synthetic services to its own recipe
  clarify bundle installation instructions
  Implemented the suggestions made by Christian and Wouter
  Replace phpDocumentor by the standard PHPDoc
  Implemented the changes suggested by reviewers
  Fixed an internal link reference
  Reviewed the Bundles cookbook articles
  Updated the list of reserved domains and the URL reference
  Use the reserved domains example.com and example.org
  Constraints - empty strings and null values
  ...
weaverryan added a commit that referenced this issue Jun 19, 2015
@weaverryan
Merge branch '2.8'
a68ff44 
* 2.8: (24 commits)
  [#5331] Tiny typo
  [#5373] Small tweak per Stof's comment
  Added depreciation note for the cascade_validation constraint and updated position of depreciation notes
  [PSR-7] Bridge documentation
  Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7
  Fixed a minor grammar issue
  Fixed typos
  Link to the official repository of the bundle.
  Added mentions to some popular (and useful) Symfony bundles
  [#5095] Fixing a typo and updating to a more realistic example
  [Components][ClassLoader] remove DebugClassLoader
  [#4228] Move synthetic services to its own recipe
  clarify bundle installation instructions
  Implemented the suggestions made by Christian and Wouter
  Replace phpDocumentor by the standard PHPDoc
  Implemented the changes suggested by reviewers
  Fixed an internal link reference
  Reviewed the Bundles cookbook articles
  Updated the list of reserved domains and the URL reference
  Use the reserved domains example.com and example.org
  ...
@wouterj wouterj removed the hasPR A Pull Request has already been submitted for this issue. label Jul 29, 2015
@wouterj
Copy link
Member Author

wouterj commented Jul 29, 2015

Checked last 2 tasks, as they are done in #5284

The first task is a little difficult, mostly because we can't find a good name for it (we discussed during the sprintday). If anyone can come up with a nice title, we can start working on it. Otherwise, I propose to just leave it in the advanced article.

@javiereguiluz
Copy link
Member

Closing it as "fixed". At the end, after the documentation reorganization, we moved the remaining topics to a new article titled "How to Create Service Aliases and Mark Services as Private". Thanks Wouter for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. DependencyInjection
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @weaverryan @wouterj