Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filesystem] Fix upper-case and lower-case inconsistencies #4450

Closed
javiereguiluz opened this issue Nov 12, 2014 · 1 comment
Closed

[Filesystem] Fix upper-case and lower-case inconsistencies #4450

javiereguiluz opened this issue Nov 12, 2014 · 1 comment
Labels
Filesystem hasPR A Pull Request has already been submitted for this issue.

Comments

@javiereguiluz
Copy link
Member

In this page: http://symfony.com/doc/master/components/filesystem/introduction.html the name of the component methods are used as the title of each subsection. The problem is that sometimes the title is upper-cased (Copy, Touch, etc.) and sometimes is not (symlink, mirror).

uppercase-lowercase-inconsistencies

Should we fix these inconsistencies? My opinion is that we should fix them and we should always use the original method name, even if that makes headings look inconsistent with the rest of the documentation.

@wouterj
Copy link
Member

wouterj commented Nov 12, 2014

I agree (I build that in my pre-alpha review bot too)

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Dec 9, 2014
weaverryan added a commit that referenced this issue Dec 11, 2014
…buh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Filesystem] filesystem headlines match method names

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4450

Commits
-------

9d77a6d filesystem headlines match method names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filesystem hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Development

No branches or pull requests

4 participants