Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.6] bootstrap form themes and form_label with checkbox #4906

Closed
weaverryan opened this issue Jan 23, 2015 · 2 comments
Closed

[2.6] bootstrap form themes and form_label with checkbox #4906

weaverryan opened this issue Jan 23, 2015 · 2 comments
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Milestone
2.6

Comments

@weaverryan
Copy link
Member

We should note that form_label should not be used on checkbox fields - it renders nothing - symfony/symfony#13501
@weaverryan weaverryan added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. Form labels Jan 23, 2015
@weaverryan weaverryan added this to the 2.6 milestone Jan 23, 2015
@weaverryan
Copy link
Member Author

Bah, nevermind, this is already included - I was looking on the wrong branch :). I'll update the issue to just be about form_label.

@weaverryan weaverryan changed the title [2.6] Document the bootstrap form themes [2.6] bootstrap form themes and form_label with checkbox Jan 23, 2015
@stof
Copy link
Member

stof commented Jan 26, 2015

You should not that this depends on the theme (the default theme does not render the label inside the widget. Only the bootstrap theme does)

This was referenced May 23, 2015
Open
Closed
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label May 23, 2015
@wouterj wouterj mentioned this issue Jun 28, 2015
Merged
xabbuh added a commit that referenced this issue Jun 28, 2015
@xabbuh
minor #5460 Finish #5291: Bootstrap form theme and checkboxes (anacic…
e181ab4 
…coni, WouterJ)

This PR was merged into the 2.6 branch.

Discussion
----------

Finish #5291: Bootstrap form theme and checkboxes

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.6+
| Fixed tickets | #4906

Replaces #5291

Commits
-------

e495337 Rewrite note a bit
32b1060 Bootstrap form theme and checkboxes
@wouterj wouterj closed this as completed Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
4 participants
@weaverryan @stof @wouterj @xabbuh