Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update voter documentation for supportsAttribute and supportsClass deprecation #5728

Closed
weaverryan opened this issue Sep 26, 2015 · 4 comments
Closed

Update voter documentation for supportsAttribute and supportsClass deprecation #5728

weaverryan opened this issue Sep 26, 2015 · 4 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Milestone
2.8

Comments

@weaverryan
Copy link
Member

See symfony/symfony#15151

This may only be components/security/authorization.rst
@weaverryan weaverryan added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. labels Sep 26, 2015
@weaverryan weaverryan added this to the 2.8 milestone Sep 26, 2015
@Koc
Copy link
Contributor

Koc commented Oct 2, 2015

cookbook/security/voters.rst also requires changes

@weaverryan
Copy link
Member Author

Further updated at symfony/symfony#16601

@weaverryan weaverryan added hasPR A Pull Request has already been submitted for this issue. and removed actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Nov 27, 2015
@weaverryan weaverryan mentioned this issue Nov 27, 2015
Merged
@weaverryan
Copy link
Member Author

PR added

@weaverryan
Copy link
Member Author

Ah, the best_practices/security.rst also needs to be updated.

@weaverryan weaverryan mentioned this issue Nov 27, 2015
Closed
@wouterj wouterj mentioned this issue Nov 28, 2015
Merged
weaverryan added a commit that referenced this issue Nov 30, 2015
@weaverryan
feature #5926 Update voter section of best practices (WouterJ)
757e159 
This PR was merged into the 2.8 branch.

Discussion
----------

Update voter section of best practices

| Q | A
| --- | ---
| Doc fix? | yes
| New docs? | yes
| Applies to | 2.8+
| Fixed tickets | #4389, #5728

Commits
-------

68da041 Update voter section of best practices
weaverryan added a commit that referenced this issue Nov 30, 2015
@weaverryan
feature #5908 Voter update (weaverryan)
0dfc7bf 
This PR was merged into the 2.8 branch.

Discussion
----------

Voter update

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.8+
| Fixed tickets | #5728

Commits
-------

31f6e3d Many tweaks thanks to a great review
5d0e6b2 tweaks thanks to Javier
a4c7d6e adding a section about calling isGranted() from within a voter
20cead6 Reworking the voter article for the new Voter class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
3 participants
@weaverryan @Koc @xabbuh