Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documenting the new CSS selector API #5782

Closed
xabbuh opened this issue Oct 12, 2015 · 0 comments
Closed

Documenting the new CSS selector API #5782

xabbuh opened this issue Oct 12, 2015 · 0 comments
Labels
actionable Clear and specific issues ready for anyone to take them. CssSelector hasPR A Pull Request has already been submitted for this issue.
Milestone
2.8

Comments

@xabbuh
Copy link
Member

xabbuh commented Oct 12, 2015

The static API of the old CssSelector class is deprecated. Instead instances of the new CssSelectorConverter class should be used (see symfony/symfony#15934).
@xabbuh xabbuh added actionable Clear and specific issues ready for anyone to take them. CssSelector labels Oct 12, 2015
@xabbuh xabbuh added this to the 2.8 milestone Oct 12, 2015
@hiddewie hiddewie mentioned this issue Oct 24, 2015
Closed
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Oct 24, 2015
@hiddewie hiddewie mentioned this issue Oct 25, 2015
Merged
weaverryan added a commit that referenced this issue Nov 5, 2015
@weaverryan
feature #5835 Updated CssSelector code example to use the new Convert…
8f24268 
…er (hiddewie)

This PR was merged into the 2.8 branch.

Discussion
----------

Updated CssSelector code example to use the new Converter

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.8
| Fixed tickets | #5782

Commits
-------

dfb9b16 Used :: for code block
df4fc7e Updated for CssSelectorConverter class name
9392f80 Updated CssSelector code example to use the new Converter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. CssSelector hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
2 participants
@weaverryan @xabbuh