Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed option deep in Validator/Valid is still present #5944

Closed
janedbal opened this issue Dec 2, 2015 · 1 comment
Closed

Removed option deep in Validator/Valid is still present #5944

janedbal opened this issue Dec 2, 2015 · 1 comment
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue. Validator

Comments

@janedbal
Copy link

janedbal commented Dec 2, 2015

Valid constraint has deprecated option deep since 2.5 and it was removed in 3.0. The deprecation isn't mentioned in previous versions of docs and the removed option are still documented in 3.0
@xabbuh xabbuh added Validator actionable Clear and specific issues ready for anyone to take them. labels Dec 4, 2015
@xabbuh
Copy link
Member

xabbuh commented Dec 4, 2015

That's good catch @janedbal! Thank you very much for reporting this. What we actually need to do is to mark the option as deprecated in the 2.7 branch (older branches are not maintained anymore except for 2.3 which is not affected by this) and after that entirely remove the option from the 3.0 branch.

@snoek09 snoek09 mentioned this issue Dec 5, 2015
Merged
@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label Dec 5, 2015
xabbuh added a commit that referenced this issue Dec 9, 2015
@xabbuh
minor #5957 mark deep option as deprecated (snoek09)
03aa3d9 
This PR was merged into the 2.7 branch.

Discussion
----------

mark deep option as deprecated

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.7
| Fixed tickets | #5944

Commits
-------

bc8293b mark deep option as deprecated
@xabbuh xabbuh closed this as completed Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue. Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wouterj @xabbuh @janedbal