Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony Security Cookbook documentation #5968

Closed
jonestristand opened this issue Dec 6, 2015 · 0 comments
Closed

Symfony Security Cookbook documentation #5968

jonestristand opened this issue Dec 6, 2015 · 0 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Security

Comments

@jonestristand
Copy link

In the Cookbook documentation for 'Using a Custom Query to Load the User' (http://symfony.com/doc/master/cookbook/security/entity_provider.html#using-a-custom-query-to-load-the-user), the example uses "implements UserProviderInterface". In the current version of Symfony the file should implement UserLoaderInterface instead. This can be seen in Symfony\Bridge\Doctrine\Security\User\EntityUserProvider where the loadUserByUsername method checks to ensure that the repository implements Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface. Can we update the document?

@xabbuh xabbuh added the Security label Dec 8, 2015
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Dec 9, 2015
xabbuh added a commit that referenced this issue Dec 23, 2015
…UserProviderInterface (ogizanagi)

This PR was merged into the 2.8 branch.

Discussion
----------

[Cookbook] [Security] Use UserLoaderInterface instead of UserProviderInterface

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.8+
| Fixed tickets | #5968

Commits
-------

79ec09a [Cookbook] [Security] Use UserLoaderInterface instead of UserProviderInterface
@xabbuh xabbuh closed this as completed Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Development

No branches or pull requests

2 participants