-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scheduler] Fix scheduler examples #19440
Conversation
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
namespace App\Scheduler; | ||
|
||
use Symfony\Component\Scheduler\Attribute\AsSchedule; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How code-block-checker
can know theses classes ?
Is adding symfony/scheduler
in its compoer.json will be enought ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this should be enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in symfony-tools/symfony-application#26 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged
Thank you Antoine. |
This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Scheduler] Document hashed Cron expression Follow #19440 Try document symfony/symfony#49792 I copied a lot https://github.com/zenstruck/schedule-bundle/blob/1.x/doc/define-tasks.md#hashed-cron-expression Commits ------- f41721c [Scheduler] Document hashed Cron expression
I tried to follow documentation and found some issues