Adapted the docs to the rename of the "virtual" form option to "inherit_data" #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR actually does 2 things: renaming |
|
@stof I would appreciate if someone else could take over that work. |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Apr 19, 2013
This PR was merged into the master branch. Discussion ---------- [2.3] [Form] Renamed option "virtual" to "inherit_data" and improved handling of such forms Bug fix: yes Feature addition: yes Backwards compatibility break: yes Symfony2 tests pass: yes Fixes the following tickets: #5899, #5720, #5578 Todo: - License of the code: MIT Documentation PR: symfony/symfony-docs#2107 This PR renames the option "virtual" to "inherit_data" for more clarity (the old option is deprecated and usable until 2.3). It also fixes the behavior of forms having that option set. Forms with that option set will now correctly return their parents' data from `getData()`, `getNormData()` and `getViewData()`. Furthermore, `getPropertyPath()` was fixed for forms that inherit their parent data. Commits ------- 1290b80 [Form] Fixed the deprecation notes for the "virtual" option ac2ca44 [Form] Moved parent data inheritance from data mappers to Form 8ea5e1a [Form] Renamed option "virtual" to "inherit_data"
fabpot
added a commit
to symfony/form
that referenced
this pull request
Apr 19, 2013
This PR was merged into the master branch. Discussion ---------- [2.3] [Form] Renamed option "virtual" to "inherit_data" and improved handling of such forms Bug fix: yes Feature addition: yes Backwards compatibility break: yes Symfony2 tests pass: yes Fixes the following tickets: #5899, #5720, #5578 Todo: - License of the code: MIT Documentation PR: symfony/symfony-docs#2107 This PR renames the option "virtual" to "inherit_data" for more clarity (the old option is deprecated and usable until 2.3). It also fixes the behavior of forms having that option set. Forms with that option set will now correctly return their parents' data from `getData()`, `getNormData()` and `getViewData()`. Furthermore, `getPropertyPath()` was fixed for forms that inherit their parent data. Commits ------- 1290b80 [Form] Fixed the deprecation notes for the "virtual" option ac2ca44 [Form] Moved parent data inheritance from data mappers to Form 8ea5e1a [Form] Renamed option "virtual" to "inherit_data"
weaverryan
added a commit
that referenced
this pull request
Apr 25, 2013
weaverryan
added a commit
that referenced
this pull request
Apr 25, 2013
…adding some versionadded details
|
Hi Bernhard! Merged with only minor sphinx tweaks (e.g. tracking down other reference to virtual). Thanks! |
fabpot
added a commit
to symfony/form
that referenced
this pull request
Nov 25, 2013
This PR was merged into the master branch. Discussion ---------- [2.3] [Form] Renamed option "virtual" to "inherit_data" and improved handling of such forms Bug fix: yes Feature addition: yes Backwards compatibility break: yes Symfony2 tests pass: yes Fixes the following tickets: #5899, #5720, #5578 Todo: - License of the code: MIT Documentation PR: symfony/symfony-docs#2107 This PR renames the option "virtual" to "inherit_data" for more clarity (the old option is deprecated and usable until 2.3). It also fixes the behavior of forms having that option set. Forms with that option set will now correctly return their parents' data from `getData()`, `getNormData()` and `getViewData()`. Furthermore, `getPropertyPath()` was fixed for forms that inherit their parent data. Commits ------- 1290b80 [Form] Fixed the deprecation notes for the "virtual" option ac2ca44 [Form] Moved parent data inheritance from data mappers to Form 8ea5e1a [Form] Renamed option "virtual" to "inherit_data"
fabpot
added a commit
to symfony/form
that referenced
this pull request
May 23, 2014
This PR was merged into the master branch. Discussion ---------- [2.3] [Form] Renamed option "virtual" to "inherit_data" and improved handling of such forms Bug fix: yes Feature addition: yes Backwards compatibility break: yes Symfony2 tests pass: yes Fixes the following tickets: #5899, #5720, #5578 Todo: - License of the code: MIT Documentation PR: symfony/symfony-docs#2107 This PR renames the option "virtual" to "inherit_data" for more clarity (the old option is deprecated and usable until 2.3). It also fixes the behavior of forms having that option set. Forms with that option set will now correctly return their parents' data from `getData()`, `getNormData()` and `getViewData()`. Furthermore, `getPropertyPath()` was fixed for forms that inherit their parent data. Commits ------- 1290b80 [Form] Fixed the deprecation notes for the "virtual" option ac2ca44 [Form] Moved parent data inheritance from data mappers to Form 8ea5e1a [Form] Renamed option "virtual" to "inherit_data"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for symfony/symfony#6573