Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WCM] Use KernelTestCase instead of WebTestCase for testing Command with a container #3244

Closed
wants to merge 3 commits into from

Conversation

johnkary
Copy link
Contributor

Q A
Doc fix? no
New docs? yes (symfony/symfony#7704)
Applies to 2.4
Fixed tickets none

This documents using the new KernelTestCase introduced in symfony/symfony#7704, which is pending acceptance and target version approval.

KernelTestCase was extracted from WebTestCase to become a more-focused base class for functional testing code that requires only a container but no client. WebTestCase is then more-focused to be used for tests requiring a client.

If you think this needs any kind of version callout in the docs to highlight the base class change we can add that too.

🚀

@xabbuh
Copy link
Member

xabbuh commented Nov 30, 2013

If it is not yet merged into 2.4, it won't apperently make it into 2.4 at all. Thus, addressing this for 2.5 and also adding a versionadded directive seems reasonable to me.

weaverryan and others added 2 commits December 8, 2013 12:26
Conflicts:
	book/security.rst
	components/property_access/introduction.rst
	components/stopwatch.rst
	cookbook/templating/namespaced_paths.rst
	reference/twig_reference.rst
@johnkary
Copy link
Contributor Author

Closing in favor of #3311 which now targets master.

@johnkary johnkary closed this Dec 11, 2013
weaverryan added a commit that referenced this pull request Mar 5, 2014
…ode only requiring the Container (johnkary)

This PR was merged into the master branch.

Discussion
----------

Use KernelTestCase instead of WebTestCase for testing code only requiring the Container

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes (symfony/symfony#9739)
| Applies to    | 2.5
| Fixed tickets | none

This documents using the new KernelTestCase introduced in symfony/symfony#9739, which was recently merged to master for 2.5-dev.

KernelTestCase was extracted from WebTestCase to become a more-focused base class for functional testing code that requires only a container but no client. WebTestCase is then more-focused to be used for tests requiring a client.

If you think this needs any kind of version callout in the docs to highlight the base class change we can add that too.

:rocket:

Previous PR #3244 against the 2.4 branch was closed because the corresponding feature was not merged into 2.4.

Commits
-------

6c52b92 [#3311] Use KernelTestCase instead of WebTestCase for tests needing only a Container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants