Removed code references to Symfony Standard Distribution #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,11 +84,10 @@ and add the following to it:: | |||
| You also need to create the file to run at the command line which creates | |||
| an ``Application`` and adds commands to it:: | |||
|
|
|||
| #!/usr/bin/env php | |||
| <?php | |||
There was a problem hiding this comment.
you should remove this tag too, it breaks highlighting.
|
Awesome 👍! I just had one quick question I posted :) |
|
@weaverryan @wouterj reverted the shebang! Let me know if it's ok now. Also I rebased and squashed it! |
|
👍 looks good now! |
|
Yes, it's great now - thanks for your hard work - it's a nice detail to have right :). Cheers! |
weaverryan
added a commit
that referenced
this pull request
Jan 9, 2014
…anielcsgomes) This PR was merged into the 2.3 branch. Discussion ---------- Removed code references to Symfony Standard Distribution | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | After talk with @wouterj on #3426 and IRC about references in the standalone Console component to the framework I decided to submit this PR to change the code that have some references to the Symfony Standard Distribution in the code. Commits ------- 4fd7022 Removed code references to Symfony Standard Distribution
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talk with @wouterj on #3426 and IRC about references in the standalone Console component to the framework I decided to submit this PR to change the code that have some references to the Symfony Standard Distribution in the code.