Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reference][Form Types] Add missing (but existing) options to "form" type #3445

Merged
merged 1 commit into from
Jan 21, 2014
Merged

[Reference][Form Types] Add missing (but existing) options to "form" type #3445

merged 1 commit into from
Jan 21, 2014

Conversation

bicpi
Copy link
Contributor

@bicpi bicpi commented Jan 8, 2014

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets #3410
  • The removed link to /cookbook/form/inherit_data_option for the inherit_data option is contained in the existing and now referenced options/inherit_data.rst.inc.
  • Fixed some formatting issues.
  • I've tweaked the empty_data description to be a bit more generic as it was focused on the choice field only.

@weaverryan
Copy link
Member

@bicpi This looks wonderful! Can you rebase to fix the conflict?

Thanks!

@bicpi
Copy link
Contributor Author

bicpi commented Jan 10, 2014

@weaverryan Rebase done, hope it's okay now :-)

@wouterj
Copy link
Member

wouterj commented Jan 10, 2014

👍

@weaverryan
Copy link
Member

Yep, looks great and clean as always. Thanks! :)

weaverryan added a commit that referenced this pull request Jan 21, 2014
…s to "form" type (bicpi)

This PR was merged into the 2.3 branch.

Discussion
----------

[Reference][Form Types] Add missing (but existing) options to "form" type

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | #3410

* The removed link to `/cookbook/form/inherit_data_option` for the `inherit_data` option is contained in the existing and now referenced `options/inherit_data.rst.inc`.
* Fixed some formatting issues.
* I've tweaked the `empty_data` description to be a bit more generic as it was focused on the `choice` field only.

Commits
-------

dc22276 [Reference][Form Types] Add missing (but existing) form options to "form" type
@weaverryan weaverryan merged commit dc22276 into symfony:2.3 Jan 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants