[WIP][Reference][Form Types] Add missing options for "form" type #3449
Conversation
I'd add it to the |
| **type**: ``string`` **default**: ``The uploaded file was too large. Please try to upload a smaller file.`` | ||
|
|
||
| This is the validation error message that's used if submitted POST form data | ||
| exceeds php.ini's ``post_max_size``. The ``{{ max }}`` placeholder can be used |
There was a problem hiding this comment.
don't we use literals for php.ini?
There was a problem hiding this comment.
we always use literals for files names, so imo we should use them too for php.ini.
|
I've done some improvements, fixes and a rebase. |
| .. caution: | ||
|
|
||
| The ``pattern`` attribute provides client-side validation for convenience | ||
| purposes only and cannot replace a reliable server-side validation. |
There was a problem hiding this comment.
maybe "[...] and must not be used as a replacement for reliable server-side validation."?
There was a problem hiding this comment.
Yes thx, sounds better. And for the HTML5, I've added this above as it was done for the required option.
|
@bicpi This is perfect. Can you rebase one more time? We've had a lot of PR's to this page lately :). Thanks! |
|
@weaverryan Rebase done. |
[WIP][Reference][Form Types] Add missing options for "form" type
|
Beautiful - thanks and cheers! |
Do we need to point out, that the
patternattribute is HTML5 only?