Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a section about using named assets #3496

Closed
wants to merge 1 commit into from

Conversation

vmattila
Copy link

This PR will add a section about named assets to the asset management page.

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@wouterj
Copy link
Member

wouterj commented Jan 21, 2014

Could you please add the PR format to your PR description?

~~~~~~~~~~~~~~~~~~

AsseticBundle configuration directives allow you to define named asset sets. You can do so
by defining the input files, filters and output files in your ``config.yml`` under ``assetic``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] in your configutation under the ``assetic``
section. Read more in the :doc:`assetic config reference </reference/configuration/assetic>`

@vmattila
Copy link
Author

Great thanks! I made the fixes, even I'm afraid I did not fully figure out the meaning of the PR Format's lines Doc fix / New docs.


AsseticBundle configuration directives allow you to define named asset sets.
You can do so by defining the input files, filters and output files in your in
your configutation under the ``assetic`` section. Read more in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doubled in your

@stof
Copy link
Member

stof commented Jan 22, 2014

Doc fix means fixing existing doc (typos, wrong explanation, ...). New doc means you are documented a new feature ("new" being related to what the doc contains, not to the fact that the code was just merged or is available but undocumented since 2 years)

),
);

After you have defined the named assets, you can reference them in your templates with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the ``@named_asset`` notation

@weaverryan
Copy link
Member

Hey Ville!

This is a great missing piece of documentation to cover - thanks for opening the PR! There are just a few comments remaining - can you make those tweaks?

Thanks!

@vmattila
Copy link
Author

vmattila commented Feb 3, 2014

Yes, they are now fixed!

@weaverryan
Copy link
Member

Wow, very fast and great job - you rock Ville! Thanks!

weaverryan added a commit that referenced this pull request Feb 4, 2014
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #3496).

Discussion
----------

Added a section about using named assets

This PR will add a section about named assets to the asset management page.

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

9c9743e Added a section about using named assets
@weaverryan weaverryan closed this Feb 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants