[HTTP Cache] Validation model: Fix header name #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the expiration model, there's a note below the code, I may add a similiar one for the validation model? The If-Modified-Since request header equals the Last-Modified header of the last response sent to the client for the particular resource. This is how the client and server communicate with each other and decide whether or not the resource has been updated since it was cached. |
|
I've added the above mentioned tip for the validation model, i.e. the equivalent tip that is used for the expiration model in the next section. |
|
Yes, obviously much more accurate now - thanks! |
weaverryan
added a commit
that referenced
this pull request
Mar 8, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [HTTP Cache] Validation model: Fix header name | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - In the cache validation model, the response sends an `ETag` header, but the following requests send an `If-None-Match` header. So the `If-None-Match` header from the request is compared to the `ETag` from the previous response. See `Symfony\Component\HttpFoundation\Request::getETags()` which is used by `Symfony\Component\HttpFoundation\Response::isNotModified()`. Commits ------- f7ef7c0 [HTTP Cache] Validation model: Fix header name
weaverryan
added a commit
that referenced
this pull request
Mar 8, 2014
I realized that the sentence on the notes was a bid hard to read. I also removed a usage of the word "client" right before this, so I can use the word "cache" instead (meaning, I want the user to be thinking about the reverse proxy, not a user's browser cache - that's valid, but not the typical use-case).
weaverryan
added a commit
that referenced
this pull request
Mar 19, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Http cache validation rewording Hiya guys! This comes after #3596. I realized that the sentence on the notes was a bid hard to read. I also removed a usage of the word "client" right before this, so I can use the word "cache" instead (meaning, I want the user to be thinking about the reverse proxy, not a user's browser cache - that's valid, but not the typical use-case). | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Thanks! Commits ------- a7cdfe9 [#3596] Tweaking language on HTTP cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cache validation model, the response sends an
ETagheader, but the following requests send anIf-None-Matchheader. So theIf-None-Matchheader from the request is compared to theETagfrom the previous response. SeeSymfony\Component\HttpFoundation\Request::getETags()which is used bySymfony\Component\HttpFoundation\Response::isNotModified().