Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some build errors #3650

Merged
merged 4 commits into from
Mar 18, 2014
Merged

Fixing some build errors #3650

merged 4 commits into from
Mar 18, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 8, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@@ -1,5 +1,7 @@
.. _checked:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, the "variables" section in the table from both button types should be removed (including this in the table was a forst try of me when documenting them)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #3677

@wouterj
Copy link
Member

wouterj commented Mar 13, 2014

Incredible to see how much slipped to the reviews...

@xabbuh
Copy link
Member Author

xabbuh commented Mar 13, 2014

Incredible to see how much slipped to the reviews...

Time for Travis...

@weaverryan
Copy link
Member

I'll try to merge in the Travis integration soon - it has been too long :).

weaverryan added a commit that referenced this pull request Mar 18, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Fixing some build errors

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

62d4a97 fix seealso directive name
62586a4 fix table syntax
72659e2 fix PHP code block
c7f2ee6 fixing doc roles
@weaverryan weaverryan merged commit 62d4a97 into symfony:2.3 Mar 18, 2014
@xabbuh xabbuh deleted the fix-doc-role branch March 18, 2014 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants