Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3712 #3716

Closed
wants to merge 3 commits into from
Closed

Fix issue #3712 #3716

wants to merge 3 commits into from

Conversation

umpirsky
Copy link
Contributor

No description provided.

@@ -249,8 +249,8 @@ If there are any issues, correct them now before moving on.
.. code-block:: bash

$ APACHEUSER=`ps aux | grep -E '[a]pache|[h]ttpd|[_]www|[w]ww-data|[n]ginx' | grep -v root | head -1 | cut -d\ -f1`
$ sudo setfacl -Rn -m u:"$APACHEUSER":rwX -m u:`whoami`:rwX app/cache app/logs
$ sudo setfacl -dRn -m u:"$APACHEUSER":rwX -m u:`whoami`:rwX app/cache app/logs
$ sudo setfacl -R -m u:"$APACHEUSER":rwX -m u:`whoami`:rwX app/cache app/logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this more of a revert? maybe try to add a note in cases when we want -dRn and in the other majority of cases when we just want the stuff working 👶

@cordoval
Copy link
Contributor

👍

@weaverryan
Copy link
Member

@umpirsky What do you think about a quick sentence after the code block?

If this doesn't work, try adding a -n flag to each command

Then we can merge, even without totally understanding what is right :)

@umpirsky
Copy link
Contributor Author

@weaverryan Hehum, I don't like writing about things I don't understand, but done. :)

@weaverryan
Copy link
Member

Thanks @umpirsky :). Actually, what do you think about just having a note about adding -n without the second code block? This section is already long, I want to be clear, but keep things somewhat short.

Can can you rebase against the 2.3 branch - e.g. git rebase master --onto 2.3? That'll help me patch this cleanly onto the 2.3 branch (no need to actually open a new PR against 2.3).

Cheers!

@umpirsky
Copy link
Contributor Author

@weaverryan Fixed. Sorry for the delay.

@xabbuh
Copy link
Member

xabbuh commented Apr 14, 2014

@umpirsky Can you please rename the APACHEUSER to HTTPDUSER. We made that change recently.

@umpirsky
Copy link
Contributor Author

@xabbuh Fixed, thanks.

@xabbuh
Copy link
Member

xabbuh commented Apr 14, 2014

👍

@weaverryan
Copy link
Member

Awesome, thanks Saša!

@weaverryan weaverryan closed this in 1853fea May 6, 2014
@umpirsky umpirsky deleted the patch-1 branch May 6, 2014 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants