-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the installation instructions for Symfony 2.5+ #3874
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, thanks for doing this - now I have several comments/questions that I think you'll appreciate @javiereguiluz :)
This is way too long - especially for the quick tour. I think we should just list the questions and the answers that they should answer.
The
Would you like to use Symfony 3 directory structure?
is not good enough. I know that's not a docs issue - it's just the first time I've seen it. As a new user, I'm stuck at this question - what does this mean? How should I answer? How would I know? Someone (me included if I can get to it) needs to make this more clear!Again, not a docs issue, but I think that the
AcmeDemoBundle
should default to "Y". All the existing demos and docs talk about the demo bundle, so we should put it there by default. If you're an advanced user, you'll know to say "N" to this. Also, this is another one where the wording is not as good as it needs to be. Better might be:@javiereguiluz Let me know what you think - most of this isn't related to the docs, just the first time I've seen this stuff and I don't like the "Symfony Experience" that we're giving new people!
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weaverryan I appreciate and 100% agree with your comment. I'm going to open an issue to try to improve Symfony installation once and for all.
However, for Symfony 2.5 we might need to update the installation instructions because it's already published and it will ask the user these questions.