-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer installation verbosity tip #4099
Conversation
you should rebase your branch on top of the upstream master branch to remove these 2 weird merge commits from the history. When creating a feature branch, it should generally be created based on the state of the upstream master branch to avoid such weirdness |
Thanks, yeah I should've done that... It's done now |
👍 thanks for adding these tips @dannykopping! However, for the |
@javiereguiluz I like adding the example code block. I would also provide an example code block for the first part of the tip. Maybe it's also better to split them into two tips as they are not really related. I would then suggest to change the wording a bit, so that you first explain the problem and provide a solution then. I think something like this is good: .. tip::
Sometimes, especially when your Internet connection is slow, running the
``composer`` command may look like it does nothing at all. You can use
the ``-vvv`` flag to let Composer print all activities it is doing in
the background:
.. code-block:: bash
$ php composer.phar create-project -vvv ... @dannykopping @javiereguiluz What do you think? |
@xabbuh I love your proposal! The only minor thing is that I think that Internet should always be capitalized. |
@javiereguiluz 👍 (updated the comment) |
Much better! Thanks |
@@ -24,7 +24,13 @@ git repository: | |||
|
|||
.. code-block:: bash | |||
|
|||
$ php composer.phar create-project symfony/framework-standard-edition path/ '~2.3' | |||
$ php composer.phar create-project symfony/framework-standard-edition path/ '~2.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the oldest still maintained Symfony version. So I don't think that this should be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, sorry - I was bringing this in line with the changes i made in #4091
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, let's change this back :)
@dannykopping What do you think about also adding example code blocks to the tips? |
In this instance specifically, or in general? |
I think it's worth to add it to all tips you added for the |
Sure, but what would you suggest putting in the 'code block'? |
I would suggest the tip to be like what I suggested in this comment. |
OK - I will clean this up tonight and implement the suggestions |
Hmm, I like what you're trying to solve here, but I'm not sure this is the correct option.
So what is the original problem? I believe it's the fact that Composer is not verbose enough at normal verbosity. I think we should solve that instead, e.g. by using the ProgressBar helper to show the progress instead of showing all details about every action done by Composer. What do you think @dannykopping ? If you agree, I would recommend to open an issue in composer/composer and see what the composer guys think about this. |
I really like that idea, given that we have the ProgressBar helper. I'll definitely add an issue in composer/composer - nice idea! |
It's already planned apparently Maybe I'll put something together over the weekend and send you a PR and a penny for your thoughts @wouterj? |
I'm not convinced that the progress bar will resolve the issue that made @dannykopping adding the |
That's a good point, but if it could be customised to show the bytes downloaded vs bytes total - that would resolve it. I'm thinking of something like a |
@xabbuh the same applies to the |
Thanks Danny for starting this! I'm ok with merging this in, but I think getting a progress bar added to Composer is much much more impactful. I hear people complain about this all the time - I would love to at least be able to show progress (and even better would be to speed up Composer - I didn't realize how many JSON requests it makes for metadata). @dannykopping I just left you 2 small comments. Thanks! |
@weaverryan for most people, the slow part is not the metadata loading, but the dependency resolution itself |
@stof I always thought that too, but when I run |
These messages look good to me now. Thanks Danny! |
* 2.3: [#4099] Adding an extra tip Added Composer installation tip Clarifying a bit more that you're passing variables into your controller Update http_cache.rst Conflicts: cookbook/workflow/new_project_git.rst
* 2.3: [#4099] Trying to get the markup just right
Added installation verbosity tip, for users with slow internet connections.
With love from slow South Africa 🌍