Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components] consistent & complete config examples #4129

Merged
merged 1 commit into from
Aug 16, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 16, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

Make configuration examples in the components section consistent throughout the different configuration formats. Also fixing several syntax issues.

This is mainly the same that I did in #4114 for the book.

Make configuration examples in the components section consistent
throughout the different configuration formats. Also fixing several
syntax issues.
@weaverryan
Copy link
Member

Another HUGE PR. Thanks @xabbuh!

@weaverryan weaverryan merged commit d08da50 into symfony:2.3 Aug 16, 2014
weaverryan added a commit that referenced this pull request Aug 16, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

[Components] consistent & complete config examples

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Make configuration examples in the components section consistent throughout the different configuration formats. Also fixing several syntax issues.

This is mainly the same that I did in #4114 for the book.

Commits
-------

d08da50 [Components] consistent & complete config examples
@xabbuh xabbuh deleted the consistent-component-code-examples branch August 16, 2014 19:11
@xabbuh
Copy link
Member Author

xabbuh commented Aug 16, 2014

Thanks for the fast merge, Ryan! :)

weaverryan added a commit that referenced this pull request Aug 25, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

[Reference] consistent & complete config examples

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Make configuration examples in the reference section consistent throughout the different configuration formats. Also fixing several syntax issues.

This follow #4114 and #4129.

Commits
-------

01dc25c [Reference] consistent & complete config examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants