Replaced old way of specifying http method by the new one #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Baptouuuu
commented
Aug 16, 2014
Baptouuuu
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.5+ |
| Fixed tickets |
|
Oops, the target branch should be |
Baptouuuu
changed the title
| @@ -53,7 +53,7 @@ system, as explained below: | |||
| <route id="remove_trailing_slash" path="/{url}"> | |||
| <default key="_controller">AcmeDemoBundle:Redirecting:removeTrailingSlash</default> | |||
| <requirement key="url">.*/$</requirement> | |||
| <requirement key="_method">GET</requirement> | |||
| <method>GET</method> | |||
There was a problem hiding this comment.
There is no method element. In XML, you have to use the methods attribute instead.
There was a problem hiding this comment.
So it would look like: <route methods="GET">...</route>? I was not sure about the xml version.
There was a problem hiding this comment.
Indeed, you can see an example as a reference here.
|
And actually, this was introduced in Symfony 2.2. So, it should be merged into the 2.3 branch. |
|
Great fix - thanks Baptiste! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.