Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookbook][Logging] document multiple recipients in XML configs #4140

Merged
merged 1 commit into from
Aug 25, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 17, 2014

Q A
Doc fix? no
New docs? yes (symfony/monolog-bundle#91)
Applies to all
Fixed tickets #3940, #4135

@stof
Copy link
Member

stof commented Aug 18, 2014

I would not put the attribute and the element in the same example. It would create an undefined config when specifying both (whether the attribute or the child elements win depend on the internal implementation of the XML config loader)

Adds an example on how to configure multiple recipients in Monolog
for sending log entries as e-mails.
@xabbuh
Copy link
Member Author

xabbuh commented Aug 18, 2014

Code pull request has been merged.

@xabbuh xabbuh changed the title [WCM][Cookbook][Logging] document multiple recipients in XML configs [Cookbook][Logging] document multiple recipients in XML configs Aug 18, 2014
@xabbuh
Copy link
Member Author

xabbuh commented Aug 21, 2014

@wouterj @weaverryan The stalled label can be replaced with a Finished label. :)

@wouterj wouterj added Finished and removed On hold labels Aug 24, 2014
@weaverryan
Copy link
Member

Great, thanks!

@weaverryan weaverryan merged commit 37ab23d into symfony:2.3 Aug 25, 2014
weaverryan added a commit that referenced this pull request Aug 25, 2014
… configs (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Logging] document multiple recipients in XML configs

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes (symfony/monolog-bundle#91)
| Applies to    | all
| Fixed tickets | #3940, #4135

Commits
-------

37ab23d document multiple recipients in XML configs
@xabbuh xabbuh deleted the monolog-91 branch August 25, 2014 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants