[WCM] Added information about the new date handling in the comparison constraints and Range #4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
webmozart
commented
Aug 18, 2014
webmozart
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony/symfony#11673) |
| Applies to | 2.6+ |
| Fixed tickets | - |
| <property name="deliveryDate"> | ||
| <constraint name="GreaterThan">today</constraint> | ||
| </property> | ||
| </class> |
There was a problem hiding this comment.
I prefer to have fully working XML examples:
<!-- src/Acme/OrderBundle/Resources/config/validation.xml -->
<?xml version="1.0" encoding="UTF-8" ?>
<constraint-mapping xmlns="http://symfony.com/schema/dic/constraint-mapping"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://symfony.com/schema/dic/constraint-mapping http://symfony.com/schema/dic/constraint-mapping/constraint-mapping-1.0.xsd">
<class name="Acme\OrderBundle\Entity\Order">
<property name="deliveryDate">
<constraint name="GreaterThan">today</constraint>
</property>
</class>
</constraint-mapping>This also applies to the other XML code blocks below.
weaverryan
changed the title
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Aug 24, 2014
…ts and Range (webmozart) This PR was merged into the 2.6-dev branch. Discussion ---------- [Validator] Added date support to comparison constraints and Range | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #3640, #7766, #9164, #9390, #8300 | License | MIT | Doc PR | symfony/symfony-docs#4143 This commit adds frequently requested functionality to compare dates. Since the `DateTime` constructor is very flexible, you can do many fancy things now such as: ```php /** * Only accept requests that start in at least an hour. * @Assert\GreaterThanOrEqual("+1 hours") */ private $date; /** * Same as before. * @Assert\Range(min = "+1 hours") */ private $date; /** * Only accept dates in the current year. * @Assert\Range(min = "first day of January", max = "first day of January next year") */ private $date; /** * Timezones are supported. * @Assert\Range(min = "first day of January UTC", max = "first day of January next year UTC") */ private $date; ``` Commits ------- 60a5863 [Validator] Added date support to comparison constraints and Range
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Aug 24, 2014
…ts and Range (webmozart) This PR was merged into the 2.6-dev branch. Discussion ---------- [Validator] Added date support to comparison constraints and Range | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #3640, #7766, #9164, #9390, #8300 | License | MIT | Doc PR | symfony/symfony-docs#4143 This commit adds frequently requested functionality to compare dates. Since the `DateTime` constructor is very flexible, you can do many fancy things now such as: ```php /** * Only accept requests that start in at least an hour. * @Assert\GreaterThanOrEqual("+1 hours") */ private $date; /** * Same as before. * @Assert\Range(min = "+1 hours") */ private $date; /** * Only accept dates in the current year. * @Assert\Range(min = "first day of January", max = "first day of January next year") */ private $date; /** * Timezones are supported. * @Assert\Range(min = "first day of January UTC", max = "first day of January next year UTC") */ private $date; ``` Commits ------- 60a5863 [Validator] Added date support to comparison constraints and Range
| } | ||
|
|
||
| Be aware that PHP will use the server's configured timezone to interpret these | ||
| dates. If you want to fix the timezone, append it to the date string: |
There was a problem hiding this comment.
I have a minor question regarding this phrase:
If you want to fix the timezone ...
Does fix always imply that something is broken? In that case, we could change it for something like this:
If you want to use a custom timezone ...
If you want to set a different timezone ...
If you want to configure the timezone explicitly ...
What I mean is that the server timezone isn't broken, it's just different from what we may need.
|
@webmozart could you please update this PR to fix the comments? |
| @@ -8,7 +8,7 @@ Validates that a value is equal to another value, defined in the options. To | |||
| force that a value is *not* equal, see :doc:`/reference/constraints/NotEqualTo`. | |||
|
|
|||
| .. caution:: | |||
|
|
|||
There was a problem hiding this comment.
Isn't it useful to explain how to compare Date instances here too?
|
@webmozart Will you be able to complete this or will you prefer if somebody takes this over? |
fago
pushed a commit
to fago/Validator
that referenced
this pull request
Apr 18, 2015
…ts and Range (webmozart) This PR was merged into the 2.6-dev branch. Discussion ---------- [Validator] Added date support to comparison constraints and Range | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #3640, #7766, #9164, #9390, #8300 | License | MIT | Doc PR | symfony/symfony-docs#4143 This commit adds frequently requested functionality to compare dates. Since the `DateTime` constructor is very flexible, you can do many fancy things now such as: ```php /** * Only accept requests that start in at least an hour. * @Assert\GreaterThanOrEqual("+1 hours") */ private $date; /** * Same as before. * @Assert\Range(min = "+1 hours") */ private $date; /** * Only accept dates in the current year. * @Assert\Range(min = "first day of January", max = "first day of January next year") */ private $date; /** * Timezones are supported. * @Assert\Range(min = "first day of January UTC", max = "first day of January next year UTC") */ private $date; ``` Commits ------- 60a5863 [Validator] Added date support to comparison constraints and Range
|
Hi @webmozart. Do you have some time soon to finish this PR? If you don't, please say so as we can then assign it to someone else during the doc sprint day on May 23rd. Thanks! |
|
This PR has been finished in #5384 |
|
closing in favor of #5384 |
weaverryan
added a commit
that referenced
this pull request
Jun 28, 2015
…mparison constraints and Range (webmozart, javiereguiluz) This PR was submitted for the 2.7 branch but it was merged into the 2.6 branch instead (closes #5384). Discussion ---------- Added information about the new date handling in the comparison constraints and Range | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#11673) | Applies to | 2.6+ | Fixed tickets | - This PR finishes #4143 Commits ------- b6c1a93 Added the "payload" option back 7ef2e6a Show annotations first e3efbbf Reordered the code blocks to show Annotations, YAML, XML and PHP 39f46e1 Fixed the issues reported by @xabbuh 7003445 Finished the documentation of the new data comparison validators 1fa69fe Added information about the new date handling in the comparison constraints and Range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.