A few small improvements to the EventDispatcher Component docs #4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I based this on the 2.3 branch as asked, just don’t know where or how I can see that here on GitHub. |
|
@GeertDD when creating the PR, you have a bar at the top which shows you the target branch and the branch of the PR. Hit "edit" and change the target branch to "2.3". You can't change the target when a PR is already opened. But no worries, our tools can cope with this, it's just a little bit easier if the PR was based on the correct branch immediately. |
|
Okay, I’ll give it a try next time. Thanks, Wouter. |
|
Great finds and fixes. Thanks so much @GeertDD! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.